You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/20 09:00:52 UTC

[GitHub] nilsd opened a new pull request #69: GH-68 (ios): Support for disabling 3D Touch link previews

nilsd opened a new pull request #69: GH-68 (ios): Support for disabling 3D Touch link previews
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/69
 
 
   ### Platforms affected
   - iOS
   
   ### What does this PR do?
   - Adding support for a new preference - `Allow3DTouchLinkPreview` - if set to `false` disables link preview popups when 3D touching links in iOS.
   
   Example usage in config.xml:
   ```
   <preference name="Allow3DTouchLinkPreview" value="false" />
   ```
   
   
   
   ### What testing has been done on this change?
   - Manually tested setting the preference to both true and false and omitting it.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org