You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/31 22:07:28 UTC
Review Request 27448: Link and connector handler minor fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira, ask questions if you are sure what this is for.
Diffs
-----
common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
Diff: https://reviews.apache.org/r/27448/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/#review59549
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Nov. 3, 2014, 2:12 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27448/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 2:12 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira, ask questions if you are !sure what this is for.
>
> It also addressed the issue Qian pointed out in (SQOOP-1650)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
> common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
> common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
> common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
> core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
> server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
>
> Diff: https://reviews.apache.org/r/27448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/
-----------------------------------------------------------
(Updated Nov. 2, 2014, 6:12 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira, ask questions if you are !sure what this is for.
It also addressed the issue Qian pointed out in (SQOOP-1650)
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
Diff: https://reviews.apache.org/r/27448/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/#review59547
-----------------------------------------------------------
Ship it!
The patch no longer applies cleanly, please rebase it and upload to JIRA, I'll commit it.
- Jarek Cecho
On Nov. 1, 2014, 1:13 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27448/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 1:13 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira, ask questions if you are !sure what this is for.
>
> It also addressed the issue Qian pointed out in (SQOOP-1650)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
> common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
> common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
> common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
> core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
> server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
>
> Diff: https://reviews.apache.org/r/27448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/#review59459
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On Nov. 1, 2014, 9:13 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27448/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 9:13 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira, ask questions if you are !sure what this is for.
>
> It also addressed the issue Qian pointed out in (SQOOP-1650)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
> common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
> common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
> common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
> core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
> server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
> server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
>
> Diff: https://reviews.apache.org/r/27448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 6:13 p.m.)
Review request for Sqoop.
Changes
-------
rebased.
Repository: sqoop-sqoop2
Description
-------
see jira, ask questions if you are !sure what this is for.
It also addressed the issue Qian pointed out in (SQOOP-1650)
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
Diff: https://reviews.apache.org/r/27448/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27448: SQOOP-1653:Link and connector handler minor
fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 2:28 p.m.)
Review request for Sqoop.
Summary (updated)
-----------------
SQOOP-1653:Link and connector handler minor fixes
Repository: sqoop-sqoop2
Description (updated)
-------
see jira, ask questions if you are !sure what this is for.
It also addressed the issue Qian pointed out in (SQOOP-1650)
Diffs
-----
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
Diff: https://reviews.apache.org/r/27448/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 27448: Link and connector handler minor fixes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27448/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 2:21 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira, ask questions if you are sure what this is for.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java 4cd3698
common/src/main/java/org/apache/sqoop/json/LinkBean.java bc59352
common/src/main/java/org/apache/sqoop/json/LinksBean.java 5858a18
common/src/main/java/org/apache/sqoop/model/MLink.java 7a9f538
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 811cbf0
core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5694ea5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 127903a
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
Diff: https://reviews.apache.org/r/27448/diff/
Testing
-------
Thanks,
Veena Basavaraj