You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/26 23:02:05 UTC

[GitHub] [iotdb] yyt86 commented on a change in pull request #4003: [IOTDB-1372]Enhance management of TsFileResource

yyt86 commented on a change in pull request #4003:
URL: https://github.com/apache/iotdb/pull/4003#discussion_r716275692



##########
File path: server/src/main/java/org/apache/iotdb/db/writelog/recover/TsFileRecoverPerformer.java
##########
@@ -296,6 +296,7 @@ private void redoLogs(
       }
 
       restorableTsFileIOWriter.endFile();
+      tsFileResource.close();

Review comment:
       We found the although the tsFileResource was set to be closed, the memory size of timeIndex for the recovered tsFileResource was larger than others and the close() method of TimeIndex was not called.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org