[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1593: docs: update controller to use adminAPIVersion=v3

[GitBox <gi...@apache.org>]

tokers commented on code in PR #1593:
URL: https://github.com/apache/apisix-ingress-controller/pull/1593#discussion_r1065479354


##########
docs/en/latest/deployments/ack.md:
##########
@@ -44,14 +44,15 @@ The script below installs APISIX and the ingress controller:
 helm repo add apisix https://charts.apiseven.com
 helm repo add bitnami https://charts.bitnami.com/bitnami
 helm repo update
-kubectl create ns ingress-apisix
 helm install apisix apisix/apisix \
   --set gateway.type=LoadBalancer \
   --set ingress-controller.enabled=true \
   --set etcd.persistence.storageClass="alicloud-disk-ssd" \
   --set etcd.persistence.size="20Gi" \
+  --create-namespace \
   --namespace ingress-apisix \
-  --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix
+  --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix \
+  --set ingress-controller.config.apisix.adminAPIVersion=v3
 kubectl get service --namespace ingress-apisix

Review Comment:
   We may add a note here to say we use APISIX 3.0 as the example so we set the `adminAPIVersion` to `v3`. If you're using APISIX 2.x, please reset it to `v2`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org