You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/08/15 13:53:43 UTC
[GitHub] [libcloud] ZuluPro opened a new pull request, #1743: Clean compute drivers
ZuluPro opened a new pull request, #1743:
URL: https://github.com/apache/libcloud/pull/1743
## Removed obsolete compute drivers
### Description
Remove:
- [ ] Bluebox
- [ ] bsnlcloud
- [*] Cloudwatt
- [ ] enomaly
- [ ] elastichosts
- [ ] elasticstack
- [ ] Kili
- [ ] gogrid
- [ ] Gridspot
- [ ] hostvirtual (now netactuate)
- [ ] Joyent
- [ ] med-1
- [ ] nephoscale
- [ ] 1and1 (now IONOS)
- [ ] profitbricks (now IONOS)
- [ ] ServerLove
- [ ] skalicloud
- [ ] Softlayer (now IBM)
- [ ] Voxel
For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.
### Status
Work in progress
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [*] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1743: Clean compute drivers
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1407470752
I believe I managed to address all the conflicts in #1852 (but I still need to go over the changes again and double check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1743: Clean compute drivers
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami merged PR #1743:
URL: https://github.com/apache/libcloud/pull/1743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1743: Clean compute drivers
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1345296754
I'm trying to sync this up with latest trunk, but it's turning out to be a bit of a pain due to the formatting changes in trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1743: Clean compute drivers
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1235802857
@ZuluPro That's for the clean up - it's always good to remove dead / unused code :)
Would appreciate if you could provide some references which document that those providers are not active / alive anymore (I did quickly check some myself and it indeed looks the companies are either dead or pivoted into a different area).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1743: Clean compute drivers
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1215058892
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1743](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4594003) into [trunk](https://codecov.io/gh/apache/libcloud/commit/26f07ac1a28b35953b84c592d6476bf65e5aacf7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26f07ac) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4594003 differs from pull request most recent head 5340278. Consider uploading reports for the commit 5340278 to get more accurate results
[](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1743 +/- ##
==========================================
- Coverage 83.29% 83.23% -0.06%
==========================================
Files 400 399 -1
Lines 87770 87758 -12
Branches 9331 9331
==========================================
- Hits 73104 73044 -60
- Misses 11486 11537 +51
+ Partials 3180 3177 -3
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/providers.py](https://codecov.io/gh/apache/libcloud/pull/1743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9wcm92aWRlcnMucHk=) | `87.50% <ø> (ø)` | |
| [libcloud/compute/types.py](https://codecov.io/gh/apache/libcloud/pull/1743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS90eXBlcy5weQ==) | `100.00% <ø> (ø)` | |
| [libcloud/compute/drivers/cloudwatt.py](https://codecov.io/gh/apache/libcloud/pull/1743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2Nsb3Vkd2F0dC5weQ==) | `0.00% <0.00%> (-81.36%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [26f07ac...5340278](https://codecov.io/gh/apache/libcloud/pull/1743?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1743: Clean compute drivers
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1407624486
#1852 has been merged. Thanks a lot of this clean up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] ZuluPro commented on pull request #1743: Clean compute drivers
Posted by GitBox <gi...@apache.org>.
ZuluPro commented on PR #1743:
URL: https://github.com/apache/libcloud/pull/1743#issuecomment-1345786583
@Kami Yes I failed too. I'm really sorry to this branch like this.
Let me try to find a solution during the next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org