You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/02/17 12:41:09 UTC

[PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

adutra opened a new pull request, #3796:
URL: https://github.com/apache/polaris/pull/3796

   Updated release workflows and manual guide to:
   
   - Set Helm chart image.tag and documentation link to the release version
   - Include artifacthub-repo.yml in the Helm chart repository
   
   Changed artifacthub-repo.yml to contain the right repository ID for Apache Polaris.
   
   <!--
   📝 Describe what changes you're proposing, especially breaking or user-facing changes. 
   📖 See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on code in PR #3796:
URL: https://github.com/apache/polaris/pull/3796#discussion_r2845956884


##########
site/content/community/release-guides/manual-release-guide.md:
##########
@@ -139,8 +139,13 @@ echo "x.y.z" > version.txt
 
 and update the version in the Helm Chart in:
 
-* `helm/polaris/Chart.yaml`
+* `helm/polaris/Chart.yaml` 
+  - update `version` and `appVersion` fields
+  - update the `Documentation` link in the `artifacthub.io/links` annotation to point to 
+    `https://polaris.apache.org/releases/x.y.z-incubating/`
 * `helm/polaris/README.md`
+* `helm/polaris/values.yaml` 
+  - update the `image.tag` field from `"latest"` to `"x.y.z-incubating"`

Review Comment:
   ```suggestion
     - update the `image.tag` field from `"latest"` to `"x.y.z"`
   ```



##########
helm/polaris/.helmignore:
##########
@@ -40,7 +40,10 @@
 .idea/
 *.tmproj
 .vscode/
+# Helm chart documentation
 helm.md
 helm.md.gotmpl
+# Helm chart testing, CI and release management
 ci/
 tests/
+artifacthub-repo.yml

Review Comment:
   Nit: mind adding a trailing newline?



##########
site/content/community/release-guides/manual-release-guide.md:
##########
@@ -139,8 +139,13 @@ echo "x.y.z" > version.txt
 
 and update the version in the Helm Chart in:
 
-* `helm/polaris/Chart.yaml`
+* `helm/polaris/Chart.yaml` 
+  - update `version` and `appVersion` fields
+  - update the `Documentation` link in the `artifacthub.io/links` annotation to point to 
+    `https://polaris.apache.org/releases/x.y.z-incubating/`

Review Comment:
   ```suggestion
       `https://polaris.apache.org/releases/x.y.z/`
   ```



##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -477,9 +477,14 @@ jobs:
           # Copy the updated index.yaml to the dist dev directory
           exec_process cp "$WORK_DIR/index.yaml" "${dist_dev_dir}/helm-chart/index.yaml"
 
-          # Commit the updated index
+          # Copy the artifacthub-repo.yml to the dist dev directory
+          exec_process cp "helm/polaris/artifacthub-repo.yml" "${dist_dev_dir}/helm-chart/artifacthub-repo.yml"
+
           exec_process cd "${dist_dev_dir}"
-          exec_process svn commit --username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive -m "Update Helm index for ${version_without_rc} RC${rc_number}"
+          # Add artifacthub-repo.yml if not already versioned
+          exec_process svn info helm-chart/artifacthub-repo.yml > /dev/null 2>&1 || exec_process svn add helm-chart/artifacthub-repo.yml

Review Comment:
   Maybe this?
   ```suggestion
             exec_process svn add helm-chart/artifacthub-repo.yml || true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on code in PR #3796:
URL: https://github.com/apache/polaris/pull/3796#discussion_r2846389947


##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -477,9 +477,14 @@ jobs:
           # Copy the updated index.yaml to the dist dev directory
           exec_process cp "$WORK_DIR/index.yaml" "${dist_dev_dir}/helm-chart/index.yaml"
 
-          # Commit the updated index
+          # Copy the artifacthub-repo.yml to the dist dev directory
+          exec_process cp "helm/polaris/artifacthub-repo.yml" "${dist_dev_dir}/helm-chart/artifacthub-repo.yml"
+
           exec_process cd "${dist_dev_dir}"
-          exec_process svn commit --username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive -m "Update Helm index for ${version_without_rc} RC${rc_number}"
+          # Add artifacthub-repo.yml if not already versioned
+          exec_process svn info helm-chart/artifacthub-repo.yml > /dev/null 2>&1 || exec_process svn add helm-chart/artifacthub-repo.yml

Review Comment:
   Should work too 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on PR #3796:
URL: https://github.com/apache/polaris/pull/3796#issuecomment-3950666149

   This PR is again ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra commented on code in PR #3796:
URL: https://github.com/apache/polaris/pull/3796#discussion_r2845950744


##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -477,9 +477,14 @@ jobs:
           # Copy the updated index.yaml to the dist dev directory
           exec_process cp "$WORK_DIR/index.yaml" "${dist_dev_dir}/helm-chart/index.yaml"
 
-          # Commit the updated index
+          # Copy the artifacthub-repo.yml to the dist dev directory
+          exec_process cp "helm/polaris/artifacthub-repo.yml" "${dist_dev_dir}/helm-chart/artifacthub-repo.yml"
+
           exec_process cd "${dist_dev_dir}"
-          exec_process svn commit --username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive -m "Update Helm index for ${version_without_rc} RC${rc_number}"
+          # Add artifacthub-repo.yml if not already versioned
+          exec_process svn info helm-chart/artifacthub-repo.yml > /dev/null 2>&1 || exec_process svn add helm-chart/artifacthub-repo.yml

Review Comment:
   This is only need to very first time we copy `artifacthub-repo.yml`.
   
   I wonder if we couldn't just do a manual `svn add` right now? This would simplify the release scripts a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Artifact Hub metadata and version-specific Helm chart updates to release process [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.

adutra merged PR #3796:
URL: https://github.com/apache/polaris/pull/3796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org