[jira] [Commented] (KAFKA-7080) WindowStoreBuilder incorrectly initializes CachingWindowStore

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651008#comment-16651008 ] 

ASF GitHub Bot commented on KAFKA-7080:
---------------------------------------

mjsax opened a new pull request #5804: KAFKA-7080 and KAFKA-7222: Cleanup overlapping KIP changes
URL: https://github.com/apache/kafka/pull/5804
 
 
   - KIP-319 and KIP-328 overlap and we can remove non-released deprecates methods
   - add upgrade docs for KIP-319
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> WindowStoreBuilder incorrectly initializes CachingWindowStore
> -------------------------------------------------------------
>
>                 Key: KAFKA-7080
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7080
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0, 1.0.1, 1.1.0, 2.0.0
>            Reporter: John Roesler
>            Assignee: John Roesler
>            Priority: Major
>             Fix For: 2.1.0
>
>
> When caching is enabled on the WindowStoreBuilder, it creates a CachingWindowStore. However, it incorrectly passes storeSupplier.segments() (the number of segments) to the segmentInterval argument.
>  
> The impact is low, since any valid number of segments is also a valid segment size, but it likely results in much smaller segments than intended. For example, the segments may be sized 3ms instead of 60,000ms.
>  
> Ideally the WindowBytesStoreSupplier interface would allow suppliers to advertise their segment size instead of segment count. I plan to create a KIP to propose this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)