You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/13 15:01:44 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3707: Fix NFS over TCP

gustavonihei commented on a change in pull request #3707:
URL: https://github.com/apache/incubator-nuttx/pull/3707#discussion_r631878319



##########
File path: fs/nfs/rpc_clnt.c
##########
@@ -241,6 +241,11 @@ static int rpcclnt_socket(FAR struct rpcclnt *rpc, in_port_t rport)
       goto bad;
     }
 
+  if (rpc->rc_sotype == SOCK_STREAM)
+    {
+      goto connect;

Review comment:
       According to the coding stardard, `goto` should only be used for exception handling:
   https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#goto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org