You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2025/04/11 04:16:53 UTC
[PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Jibing-Li opened a new pull request, #49984:
URL: https://github.com/apache/doris/pull/49984
### What problem does this PR solve?
Set sqlHash in executeInternalQuery.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2796149425
<details>
<summary>ClickBench: <b>Total hot run time: 31.2 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ac6a3c49d606fdaae2cfdd85a8dc0a3ee8697df5, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.11 0.11
query3 0.26 0.20 0.19
query4 1.60 0.17 0.19
query5 0.59 0.58 0.58
query6 1.21 0.72 0.72
query7 0.03 0.02 0.01
query8 0.04 0.04 0.03
query9 0.59 0.52 0.54
query10 0.57 0.59 0.58
query11 0.15 0.10 0.11
query12 0.15 0.11 0.12
query13 0.61 0.60 0.60
query14 2.78 2.71 2.83
query15 0.94 0.86 0.85
query16 0.38 0.37 0.38
query17 1.06 1.00 1.04
query18 0.21 0.20 0.20
query19 1.89 2.00 1.80
query20 0.02 0.01 0.01
query21 15.36 0.96 0.57
query22 0.75 1.26 0.71
query23 14.76 1.41 0.64
query24 7.04 1.32 0.83
query25 0.52 0.34 0.07
query26 0.55 0.16 0.15
query27 0.05 0.06 0.06
query28 9.36 0.89 0.44
query29 12.53 3.93 3.29
query30 0.25 0.08 0.06
query31 2.82 0.60 0.39
query32 3.23 0.56 0.50
query33 3.08 3.05 3.05
query34 15.98 5.07 4.46
query35 4.51 4.51 4.48
query36 0.66 0.48 0.48
query37 0.09 0.06 0.06
query38 0.05 0.03 0.04
query39 0.03 0.03 0.03
query40 0.17 0.14 0.13
query41 0.08 0.03 0.03
query42 0.04 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 105.19 s
Total hot run time: 31.2 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2796180941
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2819888334
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li merged PR #49984:
URL: https://github.com/apache/doris/pull/49984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2819888287
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2796039620
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2796112496
<details>
<summary>TPC-H: <b>Total hot run time: 34057 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ac6a3c49d606fdaae2cfdd85a8dc0a3ee8697df5, data reload: false
------ Round 1 ----------------------------------
q1 26130 4992 5012 4992
q2 2069 276 180 180
q3 10406 1256 715 715
q4 10227 1007 525 525
q5 7526 2325 2332 2325
q6 188 162 132 132
q7 898 730 607 607
q8 9304 1273 1086 1086
q9 6908 5099 5067 5067
q10 6804 2316 1889 1889
q11 473 283 278 278
q12 346 356 224 224
q13 17760 3703 3065 3065
q14 237 225 215 215
q15 534 483 498 483
q16 640 626 574 574
q17 599 838 369 369
q18 7412 7234 7077 7077
q19 1356 959 576 576
q20 327 335 231 231
q21 3965 3389 2467 2467
q22 1050 980 981 980
Total cold run time: 115159 ms
Total hot run time: 34057 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5140 5095 5037 5037
q2 240 344 233 233
q3 2166 2645 2272 2272
q4 1488 1867 1428 1428
q5 4400 4402 4364 4364
q6 220 170 132 132
q7 2001 1892 1771 1771
q8 2582 2542 2500 2500
q9 7243 7280 7127 7127
q10 2974 3209 2717 2717
q11 570 509 491 491
q12 677 731 611 611
q13 3483 3913 3385 3385
q14 304 285 271 271
q15 514 477 474 474
q16 635 689 642 642
q17 1145 1519 1419 1419
q18 7732 7616 7592 7592
q19 803 809 832 809
q20 1943 1957 1804 1804
q21 5320 4908 4881 4881
q22 1090 1032 977 977
Total cold run time: 52670 ms
Total hot run time: 50937 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on code in PR #49984:
URL: https://github.com/apache/doris/pull/49984#discussion_r2038930289
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() {
UUID uuid = UUID.randomUUID();
TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits());
context.setQueryId(queryId);
+ String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable());
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2795821727
<details>
<summary>TPC-H: <b>Total hot run time: 35003 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7645635e6a669401f6455a702b2f4e2cb3001445, data reload: false
------ Round 1 ----------------------------------
q1 25929 5016 4988 4988
q2 2058 264 186 186
q3 10404 1261 681 681
q4 10230 1022 521 521
q5 7472 2415 2368 2368
q6 189 161 132 132
q7 897 749 612 612
q8 9319 1301 1126 1126
q9 6774 5118 5120 5118
q10 6807 2301 1879 1879
q11 475 300 269 269
q12 344 356 213 213
q13 17774 3688 3079 3079
q14 218 233 208 208
q15 552 500 505 500
q16 619 633 594 594
q17 586 858 374 374
q18 7537 7193 7120 7120
q19 1211 946 573 573
q20 331 326 228 228
q21 4348 3539 3276 3276
q22 1044 1016 958 958
Total cold run time: 115118 ms
Total hot run time: 35003 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5138 5063 5067 5063
q2 235 333 230 230
q3 2153 2652 2290 2290
q4 1411 1844 1486 1486
q5 4530 4457 4382 4382
q6 210 166 120 120
q7 1945 1895 1699 1699
q8 2567 2511 2463 2463
q9 7323 7125 7275 7125
q10 2970 3166 2713 2713
q11 570 505 495 495
q12 673 742 588 588
q13 3547 3948 3317 3317
q14 278 300 284 284
q15 538 495 489 489
q16 644 704 668 668
q17 1138 1608 1341 1341
q18 7668 7521 7288 7288
q19 808 734 835 734
q20 2005 2005 1852 1852
q21 5245 4692 4639 4639
q22 1045 1038 981 981
Total cold run time: 52641 ms
Total hot run time: 50247 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818213629
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2795792757
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818291103
<details>
<summary>TPC-DS: <b>Total hot run time: 191569 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 50cc61744db52f8d3fbe053d63a3dd2d97afbf39, data reload: false
query1 1402 1073 1052 1052
query2 6434 1762 1737 1737
query3 11030 4436 4468 4436
query4 54317 25096 22951 22951
query5 5143 516 465 465
query6 330 192 187 187
query7 4898 492 277 277
query8 312 233 238 233
query9 5890 2564 2578 2564
query10 439 311 254 254
query11 15074 15064 15079 15064
query12 155 106 102 102
query13 1040 500 373 373
query14 9973 6300 6295 6295
query15 211 201 180 180
query16 7045 679 504 504
query17 1078 748 596 596
query18 1557 423 327 327
query19 201 204 185 185
query20 123 125 118 118
query21 205 128 103 103
query22 4285 4453 4274 4274
query23 34124 33291 33337 33291
query24 6893 2405 2414 2405
query25 458 490 390 390
query26 740 278 150 150
query27 2318 503 341 341
query28 3180 2146 2165 2146
query29 568 594 426 426
query30 276 227 188 188
query31 843 855 763 763
query32 72 59 61 59
query33 451 353 316 316
query34 774 868 508 508
query35 811 833 761 761
query36 943 1000 893 893
query37 113 106 78 78
query38 4182 4198 4178 4178
query39 1506 1429 1489 1429
query40 229 121 106 106
query41 56 51 51 51
query42 128 114 113 113
query43 491 530 485 485
query44 1309 820 826 820
query45 179 179 165 165
query46 834 1032 636 636
query47 1866 1875 1750 1750
query48 376 408 305 305
query49 700 508 441 441
query50 641 689 405 405
query51 4254 4204 4151 4151
query52 122 110 105 105
query53 232 260 186 186
query54 577 592 519 519
query55 86 82 86 82
query56 309 293 266 266
query57 1170 1207 1116 1116
query58 266 280 262 262
query59 2733 2753 2780 2753
query60 334 323 308 308
query61 129 125 131 125
query62 738 773 681 681
query63 214 185 193 185
query64 1995 1061 679 679
query65 4303 4275 4224 4224
query66 780 390 353 353
query67 15730 15448 15171 15171
query68 7201 875 505 505
query69 530 300 259 259
query70 1177 1137 1094 1094
query71 491 311 282 282
query72 5636 4717 4736 4717
query73 1394 604 343 343
query74 9001 8874 8869 8869
query75 3829 3212 2667 2667
query76 4220 1185 748 748
query77 616 355 286 286
query78 10029 10052 9255 9255
query79 2351 814 558 558
query80 614 513 461 461
query81 480 263 221 221
query82 442 132 95 95
query83 373 242 230 230
query84 288 111 85 85
query85 800 350 308 308
query86 367 287 300 287
query87 4371 4461 4356 4356
query88 3532 2228 2220 2220
query89 402 310 275 275
query90 1917 208 202 202
query91 141 143 118 118
query92 77 60 55 55
query93 1664 934 590 590
query94 672 409 278 278
query95 365 291 287 287
query96 475 563 268 268
query97 3170 3219 3155 3155
query98 229 202 212 202
query99 1418 1397 1251 1251
Total cold run time: 298447 ms
Total hot run time: 191569 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818270032
<details>
<summary>TPC-H: <b>Total hot run time: 33895 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 50cc61744db52f8d3fbe053d63a3dd2d97afbf39, data reload: false
------ Round 1 ----------------------------------
q1 26303 5087 5026 5026
q2 2061 292 187 187
q3 10685 1214 695 695
q4 10239 987 533 533
q5 7646 2401 2334 2334
q6 183 164 129 129
q7 908 728 599 599
q8 9310 1249 1078 1078
q9 6765 5098 5102 5098
q10 6839 2289 1906 1906
q11 494 300 264 264
q12 340 354 222 222
q13 17765 3666 3136 3136
q14 241 226 212 212
q15 532 481 492 481
q16 451 444 403 403
q17 588 840 346 346
q18 7309 7127 7082 7082
q19 1284 936 539 539
q20 325 326 216 216
q21 3938 2610 2442 2442
q22 1034 981 967 967
Total cold run time: 115240 ms
Total hot run time: 33895 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5141 5075 5200 5075
q2 233 322 231 231
q3 2157 2676 2309 2309
q4 1432 1808 1336 1336
q5 4412 4375 4363 4363
q6 223 167 134 134
q7 1990 1906 1755 1755
q8 2633 2641 2534 2534
q9 7204 7247 7018 7018
q10 3104 3167 2726 2726
q11 578 508 497 497
q12 683 749 631 631
q13 3528 3907 3303 3303
q14 292 324 263 263
q15 524 488 482 482
q16 457 515 483 483
q17 1148 1526 1362 1362
q18 7691 7566 7364 7364
q19 799 766 810 766
q20 2030 1991 1818 1818
q21 5183 4987 4736 4736
q22 1074 1051 1034 1034
Total cold run time: 52516 ms
Total hot run time: 50220 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818299036
<details>
<summary>ClickBench: <b>Total hot run time: 29.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 50cc61744db52f8d3fbe053d63a3dd2d97afbf39, data reload: false
query1 0.04 0.04 0.02
query2 0.12 0.10 0.11
query3 0.26 0.19 0.19
query4 1.60 0.19 0.20
query5 0.59 0.58 0.57
query6 1.18 0.71 0.72
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.57 0.56 0.51
query10 0.57 0.56 0.56
query11 0.15 0.10 0.11
query12 0.15 0.11 0.11
query13 0.62 0.60 0.59
query14 1.14 1.21 1.17
query15 0.86 0.85 0.84
query16 0.38 0.39 0.38
query17 1.04 0.99 1.02
query18 0.21 0.19 0.19
query19 1.83 1.81 1.73
query20 0.02 0.01 0.01
query21 15.40 0.89 0.56
query22 0.78 1.13 0.59
query23 15.06 1.32 0.60
query24 7.08 1.10 1.53
query25 0.51 0.16 0.19
query26 0.52 0.16 0.14
query27 0.05 0.04 0.05
query28 10.36 0.79 0.41
query29 12.61 3.96 3.30
query30 0.25 0.09 0.07
query31 2.84 0.59 0.38
query32 3.22 0.54 0.46
query33 2.99 3.07 3.08
query34 15.75 5.08 4.47
query35 4.53 4.53 4.49
query36 0.67 0.49 0.49
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.14 0.14
query41 0.08 0.03 0.03
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 104.5 s
Total hot run time: 29.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2795841681
<details>
<summary>ClickBench: <b>Total hot run time: 31.2 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7645635e6a669401f6455a702b2f4e2cb3001445, data reload: false
query1 0.04 0.04 0.04
query2 0.12 0.11 0.10
query3 0.25 0.19 0.19
query4 1.60 0.20 0.11
query5 0.55 0.56 0.54
query6 1.21 0.72 0.71
query7 0.03 0.01 0.01
query8 0.03 0.04 0.04
query9 0.57 0.52 0.51
query10 0.64 0.60 0.58
query11 0.15 0.10 0.10
query12 0.14 0.11 0.11
query13 0.61 0.60 0.59
query14 2.66 2.80 2.70
query15 0.93 0.86 0.85
query16 0.37 0.38 0.38
query17 1.01 1.07 1.01
query18 0.21 0.20 0.19
query19 2.01 1.94 1.78
query20 0.01 0.01 0.01
query21 15.35 0.89 0.55
query22 0.73 1.22 0.65
query23 14.97 1.41 0.62
query24 7.12 1.31 1.16
query25 0.50 0.18 0.12
query26 0.60 0.16 0.13
query27 0.05 0.05 0.06
query28 9.91 0.88 0.43
query29 12.85 3.92 3.27
query30 0.25 0.10 0.06
query31 2.83 0.59 0.40
query32 3.23 0.55 0.47
query33 3.09 3.02 3.03
query34 15.75 5.06 4.46
query35 4.45 4.52 4.45
query36 0.66 0.49 0.48
query37 0.09 0.07 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.13 0.13
query41 0.08 0.04 0.03
query42 0.03 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 105.98 s
Total hot run time: 31.2 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2797196902
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2795793044
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #49984:
URL: https://github.com/apache/doris/pull/49984#discussion_r2038821228
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() {
UUID uuid = UUID.randomUUID();
TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits());
context.setQueryId(queryId);
+ String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable());
Review Comment:
internal sql is always written with Doris' dialect, so it should not convert by dialect?
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() {
UUID uuid = UUID.randomUUID();
TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits());
context.setQueryId(queryId);
+ String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable());
+ if (stmt != null) {
+ context.setSqlHash(DigestUtils.md5Hex(stmt));
+ }
Review Comment:
could we add a ut to ensure it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818698476
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2818701361
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on code in PR #49984:
URL: https://github.com/apache/doris/pull/49984#discussion_r2038925101
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() {
UUID uuid = UUID.randomUUID();
TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits());
context.setQueryId(queryId);
+ String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable());
+ if (stmt != null) {
+ context.setSqlHash(DigestUtils.md5Hex(stmt));
+ }
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2796138575
<details>
<summary>TPC-DS: <b>Total hot run time: 193670 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ac6a3c49d606fdaae2cfdd85a8dc0a3ee8697df5, data reload: false
query1 1400 1044 1029 1029
query2 6110 1899 1910 1899
query3 10984 4528 4458 4458
query4 53739 25327 23597 23597
query5 5090 517 465 465
query6 371 207 200 200
query7 4990 508 277 277
query8 296 249 231 231
query9 5885 2588 2587 2587
query10 429 312 260 260
query11 15088 15109 15131 15109
query12 166 115 105 105
query13 1121 494 413 413
query14 10097 6200 6204 6200
query15 189 202 185 185
query16 7093 635 504 504
query17 1122 801 598 598
query18 1572 410 316 316
query19 199 190 164 164
query20 134 125 123 123
query21 213 126 105 105
query22 4336 4554 4298 4298
query23 34188 33563 33487 33487
query24 6919 2411 2416 2411
query25 466 476 457 457
query26 668 285 162 162
query27 2216 508 345 345
query28 3125 2445 2445 2445
query29 613 603 443 443
query30 272 224 192 192
query31 889 857 807 807
query32 71 63 73 63
query33 474 366 309 309
query34 768 873 532 532
query35 811 874 780 780
query36 941 989 940 940
query37 121 143 87 87
query38 4155 4184 4134 4134
query39 1485 1476 1442 1442
query40 211 123 105 105
query41 57 54 51 51
query42 121 113 109 109
query43 512 504 473 473
query44 1347 828 814 814
query45 186 175 171 171
query46 833 1024 640 640
query47 1885 1906 1828 1828
query48 397 442 320 320
query49 690 544 456 456
query50 668 695 408 408
query51 4228 4245 4217 4217
query52 110 115 103 103
query53 231 266 200 200
query54 580 597 518 518
query55 87 86 87 86
query56 316 311 300 300
query57 1218 1231 1135 1135
query58 277 260 274 260
query59 2791 2858 2838 2838
query60 334 351 336 336
query61 155 158 155 155
query62 722 746 673 673
query63 232 191 198 191
query64 1569 1073 701 701
query65 4301 4233 4256 4233
query66 729 405 316 316
query67 15894 15736 15363 15363
query68 6382 871 512 512
query69 555 290 268 268
query70 1232 1115 1069 1069
query71 445 314 280 280
query72 5686 4864 4733 4733
query73 1231 621 341 341
query74 9205 9060 8624 8624
query75 3387 3220 2730 2730
query76 3867 1188 741 741
query77 543 406 282 282
query78 10013 9977 9275 9275
query79 2169 812 567 567
query80 604 516 456 456
query81 488 255 220 220
query82 468 132 109 109
query83 252 252 241 241
query84 293 111 89 89
query85 780 360 324 324
query86 385 301 291 291
query87 4482 4544 4387 4387
query88 3481 2251 2244 2244
query89 407 312 289 289
query90 1786 210 212 210
query91 147 149 112 112
query92 74 60 54 54
query93 1843 959 575 575
query94 703 396 304 304
query95 362 288 287 287
query96 488 570 280 280
query97 3164 3224 3132 3132
query98 231 227 201 201
query99 1340 1398 1284 1284
Total cold run time: 295980 ms
Total hot run time: 193670 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](auditlog)Set sqlHash in executeInternalQuery [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #49984:
URL: https://github.com/apache/doris/pull/49984#issuecomment-2795835586
<details>
<summary>TPC-DS: <b>Total hot run time: 185936 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7645635e6a669401f6455a702b2f4e2cb3001445, data reload: false
query1 1021 498 481 481
query2 6533 1948 1938 1938
query3 6742 219 220 219
query4 26217 23789 23032 23032
query5 4312 624 473 473
query6 305 210 194 194
query7 4624 483 283 283
query8 293 250 242 242
query9 8617 2587 2576 2576
query10 447 326 268 268
query11 15716 15036 14908 14908
query12 163 109 104 104
query13 1650 494 383 383
query14 9455 6063 6171 6063
query15 205 191 174 174
query16 7243 636 487 487
query17 1167 712 544 544
query18 1968 391 298 298
query19 185 179 148 148
query20 121 121 118 118
query21 210 125 102 102
query22 4125 4061 4060 4060
query23 33759 32896 33033 32896
query24 8443 2383 2386 2383
query25 525 456 387 387
query26 1224 267 146 146
query27 2769 502 328 328
query28 4355 2400 2412 2400
query29 744 545 439 439
query30 286 217 195 195
query31 940 868 775 775
query32 70 61 63 61
query33 566 381 304 304
query34 782 869 507 507
query35 825 830 754 754
query36 957 999 892 892
query37 125 103 75 75
query38 4138 4176 4080 4080
query39 1443 1400 1418 1400
query40 210 119 106 106
query41 55 51 51 51
query42 119 104 104 104
query43 488 495 474 474
query44 1277 801 793 793
query45 177 169 166 166
query46 823 1020 617 617
query47 1726 1790 1728 1728
query48 376 423 309 309
query49 807 520 434 434
query50 642 680 399 399
query51 4160 4187 4071 4071
query52 111 107 99 99
query53 229 257 184 184
query54 589 610 521 521
query55 81 82 86 82
query56 326 311 286 286
query57 1109 1151 1086 1086
query58 280 271 267 267
query59 2719 2708 2632 2632
query60 357 341 316 316
query61 156 153 155 153
query62 822 776 686 686
query63 222 190 183 183
query64 4338 1004 667 667
query65 4355 4248 4246 4246
query66 1113 420 315 315
query67 15543 15271 15230 15230
query68 8667 880 511 511
query69 474 327 277 277
query70 1185 1122 1059 1059
query71 473 307 295 295
query72 5602 4777 5200 4777
query73 748 686 347 347
query74 9121 9151 8710 8710
query75 4155 3218 2709 2709
query76 3672 1203 766 766
query77 779 371 283 283
query78 9879 10100 9237 9237
query79 2197 868 570 570
query80 629 504 437 437
query81 461 250 223 223
query82 433 131 153 131
query83 294 248 243 243
query84 298 103 84 84
query85 804 355 316 316
query86 338 308 282 282
query87 4421 4469 4416 4416
query88 2958 2234 2242 2234
query89 388 319 291 291
query90 1953 211 206 206
query91 143 145 114 114
query92 78 61 56 56
query93 1234 969 572 572
query94 670 399 302 302
query95 371 292 283 283
query96 538 565 280 280
query97 3150 3194 3151 3151
query98 240 199 209 199
query99 1421 1415 1253 1253
Total cold run time: 274254 ms
Total hot run time: 185936 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org