You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by nkurihar <gi...@git.apache.org> on 2017/06/28 00:08:40 UTC

[GitHub] incubator-pulsar pull request #535: Enable TLS Client Authentication on WebS...

GitHub user nkurihar opened a pull request:

    https://github.com/apache/incubator-pulsar/pull/535

    Enable TLS Client Authentication  on WebSocketProxy and DiscoveryService

    ### Motivation
    
    * `tlsTrustCertsFilePath` in `ProxyServer` is not configurable
    * `tlsTrustCertsFilePath` and `tlsAllowInsecureConnection` in `ServerManager` and `ServiceChannelInitializer` is not configurable
    
    To use TLS Client Authentication on WebSocketProxy and DiscoveryService, they should be configurable.
    
    ### Modifications
    
    * Enable `ProxyServer` to set `tlsTrustCertsFilePath`
    * Enable `ServerManager` and `ServiceChannelInitializer` to set `tlsTrustCertsFilePath` and `tlsAllowInsecureConnection`
    
    ### Result
    
    We can use TLS Client Authentication on WebSocketProxy and DiscoveryService.
    
    Note:
    I'm going to add test codes for TLS client authentication as another Pull-Request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nkurihar/pulsar tls-client-auth

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pulsar/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit 1cbfb7286847faebb0c69e0669a6537572d78354
Author: Nozomi Kurihara <nk...@yahoo-corp.jp>
Date:   2017-06-27T23:38:58Z

    Enable ProxyServer to set tlsTrustCertsFilePath for TLS Client Authentication

commit 2eb6b1ab7ca1a265cca7e8fa94a010223ca1f809
Author: Nozomi Kurihara <nk...@yahoo-corp.jp>
Date:   2017-06-23T20:21:24Z

    Enable DiscoveryService to set tlsTrustCertsFilePath / tlsAllowInsecureConnection for TLS Client Authentication

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---