You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/10/28 12:13:32 UTC

[PR] Disable annotation processing (and avoid build warnings) [jena]

afs opened a new pull request, #2065:
URL: https://github.com/apache/jena/pull/2065

   Planned permanent change:
   https://bugs.openjdk.org/browse/JDK-8306819
   
   with notes/warnings in Java 22
   https://bugs.openjdk.org/browse/JDK-8310061
   
   and backported to Java21:
   https://bugs.openjdk.org/browse/JDK-8311073
   
   This PR is a build-related cleanup for Java21, which is compatible with Java17. 
   In Java21, there were build warnings from javac about "annotation processing"
   
   ---
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Disable annotation processing (and avoid build warnings) [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #2065:
URL: https://github.com/apache/jena/pull/2065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Disable annotation processing (and avoid build warnings) [jena]

Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2065:
URL: https://github.com/apache/jena/pull/2065#issuecomment-1783797635

   Easy to review but I will do so later when I have time to read the links (they look interesting! thanks!).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Disable annotation processing (and avoid build warnings) [jena]

Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #2065:
URL: https://github.com/apache/jena/pull/2065#issuecomment-1783880147

   Can't count how many times I found useful articles in baeldung.com.
   
   >A key point is that it can only generate new files, not modify or affect compile time input files.
   >This is good to know - it means none of JUnit nor the Contract Testing is affected.
   
   :+1: 
   
   Thank you! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Disable annotation processing (and avoid build warnings) [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #2065:
URL: https://github.com/apache/jena/pull/2065#issuecomment-1783841286

   > this can be applied to any Java project that's not creating custom annotations in java?
   
   Yes.
   
   I didn't know much/anything about annotation processing until I started to track down the cause of the Java21 compiler warning messages.
   
   This was useful:
   https://www.baeldung.com/java-annotation-processing-builder
   
   A key point is that it can only generate new files, not modify or affect compile time input files.
   This is good to know - it means none of JUnit nor the Contract Testing is affected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] Disable annotation processing (and avoid build warnings) [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #2065:
URL: https://github.com/apache/jena/pull/2065#issuecomment-1783798426

   Not the largest PR ever!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org