[GitHub] [spark] cloud-fan commented on a diff in pull request #40466: [SPARK-42835][SQL][TESTS] Add test cases for `Column.explain`

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40466:
URL: https://github.com/apache/spark/pull/40466#discussion_r1141966325


##########
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala:
##########
@@ -921,6 +922,132 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
     }
   }
 
+  private def captureStdOut(block: => Unit): String = {
+    val capturedOut = new ByteArrayOutputStream()
+    Console.withOut(capturedOut)(block)
+    capturedOut.toString()
+  }
+
+  test("explain") {

Review Comment:
   shall we use golden file tests? We don't expect it to be stable but we should be aware if it gets changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org