You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2013/12/03 01:18:52 UTC

Re: client timezone and flickering

Hello Martin,

I finally was able implement this feature :)
Could you please take a look at it?
https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/ClientInfoBehavior.java

If it is generally OK I can try to create pull request
Unfortunately it was impossible for me to reuse existent BrowserInfoForm
without modifications :(
What I have changed is:
1) extract javascript from html to *.js file (to be able to use it in my
code)
2) split submitForm into 2 methods: fill+submit
3) make the form accessible outside the class
https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/BrowserInfoForm.java

Will wait for feedback from you :)




On Wed, Sep 11, 2013 at 3:27 PM, Maxim Solodovnik <so...@gmail.com>wrote:

> Will try :)
>
>
> On Wed, Sep 11, 2013 at 3:20 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>> Implement it and attach it to a ticket.
>>
>>
>> On Wed, Sep 11, 2013 at 11:15 AM, Maxim Solodovnik <solomax666@gmail.com
>> >wrote:
>>
>> > Would be nice to have WebSession#getAjaxClientInfo out of the box :)
>> >
>> >
>> > On Wed, Sep 11, 2013 at 2:17 PM, Martin Grigorov <mgrigorov@apache.org
>> > >wrote:
>> >
>> > > Hi,
>> > >
>> > > By default Wicket redirects temporarily to a special page where
>> > JavaScript
>> > > extracts the info and sends it back to the server.
>> > > You may need custom solution that does this logic with Ajax in the
>> > > background.
>> > >
>> > >
>> > > On Tue, Sep 10, 2013 at 7:43 PM, infiniter <in...@gmail.com>
>> wrote:
>> > >
>> > > > has anyone been able to get around the flicker issue when getting
>> the
>> > > > client
>> > > > timezone from WebSession#getClientInfo in a painless way?
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > View this message in context:
>> > > >
>> > >
>> >
>> http://apache-wicket.1842946.n4.nabble.com/client-timezone-and-flickering-tp4661284.html
>> > > > Sent from the Users forum mailing list archive at Nabble.com.
>> > > >
>> > > >
>> ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> > > > For additional commands, e-mail: users-help@wicket.apache.org
>> > > >
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>> >
>>
>
>
>
> --
> WBR
> Maxim aka solomax
>



-- 
WBR
Maxim aka solomax

Re: client timezone and flickering

Posted by Maxim Solodovnik <so...@gmail.com>.

Done: https://issues.apache.org/jira/browse/WICKET-5435

Thanks!


On Tue, Dec 3, 2013 at 4:08 PM, Martin Grigorov <mg...@apache.org>wrote:

> Hi Maxim,
>
> Please file a ticket in Wicket Jira for this feature request.
> Link to this discussion and to your repository.
> There are some things I don't like in ClientInfoBehavior but we will
> improve it.
> Thanks!
>
>
> On Tue, Dec 3, 2013 at 1:18 AM, Maxim Solodovnik <solomax666@gmail.com
> >wrote:
>
> > Hello Martin,
> >
> > I finally was able implement this feature :)
> > Could you please take a look at it?
> >
> >
> https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/ClientInfoBehavior.java
> >
> > If it is generally OK I can try to create pull request
> > Unfortunately it was impossible for me to reuse existent BrowserInfoForm
> > without modifications :(
> > What I have changed is:
> > 1) extract javascript from html to *.js file (to be able to use it in my
> > code)
> > 2) split submitForm into 2 methods: fill+submit
> > 3) make the form accessible outside the class
> >
> >
> https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/BrowserInfoForm.java
> >
> > Will wait for feedback from you :)
> >
> >
> >
> >
> > On Wed, Sep 11, 2013 at 3:27 PM, Maxim Solodovnik <solomax666@gmail.com
> > >wrote:
> >
> > > Will try :)
> > >
> > >
> > > On Wed, Sep 11, 2013 at 3:20 PM, Martin Grigorov <mgrigorov@apache.org
> > >wrote:
> > >
> > >> Implement it and attach it to a ticket.
> > >>
> > >>
> > >> On Wed, Sep 11, 2013 at 11:15 AM, Maxim Solodovnik <
> > solomax666@gmail.com
> > >> >wrote:
> > >>
> > >> > Would be nice to have WebSession#getAjaxClientInfo out of the box :)
> > >> >
> > >> >
> > >> > On Wed, Sep 11, 2013 at 2:17 PM, Martin Grigorov <
> > mgrigorov@apache.org
> > >> > >wrote:
> > >> >
> > >> > > Hi,
> > >> > >
> > >> > > By default Wicket redirects temporarily to a special page where
> > >> > JavaScript
> > >> > > extracts the info and sends it back to the server.
> > >> > > You may need custom solution that does this logic with Ajax in the
> > >> > > background.
> > >> > >
> > >> > >
> > >> > > On Tue, Sep 10, 2013 at 7:43 PM, infiniter <in...@gmail.com>
> > >> wrote:
> > >> > >
> > >> > > > has anyone been able to get around the flicker issue when
> getting
> > >> the
> > >> > > > client
> > >> > > > timezone from WebSession#getClientInfo in a painless way?
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > > View this message in context:
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> http://apache-wicket.1842946.n4.nabble.com/client-timezone-and-flickering-tp4661284.html
> > >> > > > Sent from the Users forum mailing list archive at Nabble.com.
> > >> > > >
> > >> > > >
> > >> ---------------------------------------------------------------------
> > >> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > >> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > >> > > >
> > >> > > >
> > >> > >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > WBR
> > >> > Maxim aka solomax
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>



-- 
WBR
Maxim aka solomax

Re: client timezone and flickering

Posted by Martin Grigorov <mg...@apache.org>.

Hi Maxim,

Please file a ticket in Wicket Jira for this feature request.
Link to this discussion and to your repository.
There are some things I don't like in ClientInfoBehavior but we will
improve it.
Thanks!


On Tue, Dec 3, 2013 at 1:18 AM, Maxim Solodovnik <so...@gmail.com>wrote:

> Hello Martin,
>
> I finally was able implement this feature :)
> Could you please take a look at it?
>
> https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/ClientInfoBehavior.java
>
> If it is generally OK I can try to create pull request
> Unfortunately it was impossible for me to reuse existent BrowserInfoForm
> without modifications :(
> What I have changed is:
> 1) extract javascript from html to *.js file (to be able to use it in my
> code)
> 2) split submitForm into 2 methods: fill+submit
> 3) make the form accessible outside the class
>
> https://github.com/solomax/ajax-client-info/blob/master/src/main/java/org/ajax/BrowserInfoForm.java
>
> Will wait for feedback from you :)
>
>
>
>
> On Wed, Sep 11, 2013 at 3:27 PM, Maxim Solodovnik <solomax666@gmail.com
> >wrote:
>
> > Will try :)
> >
> >
> > On Wed, Sep 11, 2013 at 3:20 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >
> >> Implement it and attach it to a ticket.
> >>
> >>
> >> On Wed, Sep 11, 2013 at 11:15 AM, Maxim Solodovnik <
> solomax666@gmail.com
> >> >wrote:
> >>
> >> > Would be nice to have WebSession#getAjaxClientInfo out of the box :)
> >> >
> >> >
> >> > On Wed, Sep 11, 2013 at 2:17 PM, Martin Grigorov <
> mgrigorov@apache.org
> >> > >wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > By default Wicket redirects temporarily to a special page where
> >> > JavaScript
> >> > > extracts the info and sends it back to the server.
> >> > > You may need custom solution that does this logic with Ajax in the
> >> > > background.
> >> > >
> >> > >
> >> > > On Tue, Sep 10, 2013 at 7:43 PM, infiniter <in...@gmail.com>
> >> wrote:
> >> > >
> >> > > > has anyone been able to get around the flicker issue when getting
> >> the
> >> > > > client
> >> > > > timezone from WebSession#getClientInfo in a painless way?
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > View this message in context:
> >> > > >
> >> > >
> >> >
> >>
> http://apache-wicket.1842946.n4.nabble.com/client-timezone-and-flickering-tp4661284.html
> >> > > > Sent from the Users forum mailing list archive at Nabble.com.
> >> > > >
> >> > > >
> >> ---------------------------------------------------------------------
> >> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> >> > > > For additional commands, e-mail: users-help@wicket.apache.org
> >> > > >
> >> > > >
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >> >
> >>
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>