You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/30 12:51:59 UTC

[GitHub] [beam] alexeyinkin commented on a diff in pull request #22959: Listen to window messages to switch SDK and to load content

alexeyinkin commented on code in PR #22959:
URL: https://github.com/apache/beam/pull/22959#discussion_r958440212


##########
playground/frontend/lib/pages/playground/states/playground_state.dart:
##########
@@ -169,13 +174,12 @@ class PlaygroundState with ChangeNotifier {
 
   void setSdk(
     SDK sdk, {
-    required bool loadDefaultIfNot,

Review Comment:
   This was an odd thing to allow clients to set. `false` here was only used when setting an example before setting the actual content. So that location was changed to not calling this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org