You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/09 18:05:33 UTC

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties

adam-markovics commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r822937105



##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
     if (running_)
       return;
     running_ = true;
-    thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+    thread_ = std::thread(&ProvenanceRepository::run, this);

Review comment:
       They are supposed to be in this one. Unless it is urgent to merge, then it's free to merge and then I'll open another PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org