You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/05 03:21:26 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1300: performance optimization: change time.After => time.NewTimer for 3.0
codecov-commenter commented on pull request #1300:
URL: https://github.com/apache/dubbo-go/pull/1300#issuecomment-873755070
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1300](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (512882c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/e3bbd34d21318ea08c6b10c98cad6f156bd73c74?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3bbd34) will **increase** coverage by `0.60%`.
> The diff coverage is `78.84%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1300 +/- ##
==========================================
+ Coverage 55.58% 56.18% +0.60%
==========================================
Files 272 273 +1
Lines 12809 12780 -29
==========================================
+ Hits 7120 7181 +61
+ Misses 4783 4694 -89
+ Partials 906 905 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ster/router/v3router/judger/method\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvanVkZ2VyL21ldGhvZF9tYXRjaF9qdWRnZXIuZ28=) | `60.71% <ø> (+60.71%)` | :arrow_up: |
| [cluster/router/v3router/uniform\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvdW5pZm9ybV9yb3V0ZS5nbw==) | `57.14% <ø> (-5.36%)` | :arrow_down: |
| [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `0.00% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `47.05% <0.00%> (ø)` | |
| [filter/filter\_impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dyYWNlZnVsX3NodXRkb3duX2ZpbHRlci5nbw==) | `55.17% <20.00%> (-15.20%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `14.28% <50.00%> (-6.47%)` | :arrow_down: |
| [.../router/v3router/judger/attachment\_match\_judger.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvanVkZ2VyL2F0dGFjaG1lbnRfbWF0Y2hfanVkZ2VyLmdv) | `66.66% <61.53%> (+30.95%)` | :arrow_up: |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `76.27% <66.66%> (+0.40%)` | :arrow_up: |
| [config/remote\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlbW90ZV9jb25maWcuZ28=) | `68.00% <70.00%> (-8.48%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `60.00% <83.33%> (-3.50%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/1300/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [893bfb5...512882c](https://codecov.io/gh/apache/dubbo-go/pull/1300?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org