You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Jaydeep Vishwakarma <ja...@gmail.com> on 2016/03/01 10:49:55 UTC
Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed when
coordinator action get killed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-2243
https://issues.apache.org/jira/browse/OOZIE-2243
Repository: oozie-git
Description
-------
Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 4fc0c52
core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ef6b99d
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 20e4caf
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 2939b60
core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 86f0ed2
hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
Diff: https://reviews.apache.org/r/44204/diff/
Testing
-------
done
Thanks,
Jaydeep Vishwakarma
Re: Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed
when coordinator action get killed
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/#review150170
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 547)
<https://reviews.apache.org/r/44204/#comment218040>
Assume.assumeTrue takes only one parameter.
- Jaydeep Vishwakarma
On Aug. 27, 2016, 7:46 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44204/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2016, 7:46 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2243
> https://issues.apache.org/jira/browse/OOZIE-2243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e546e77
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ed06707
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1ea7097
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 5f9e29a
> hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
> hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
> hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
>
> Diff: https://reviews.apache.org/r/44204/diff/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed
when coordinator action get killed
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Sept. 19, 2016, 11:44 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java, line 548
> > <https://reviews.apache.org/r/44204/diff/2/?file=1487474#file1487474line548>
> >
> > Assume.assumeTrue("Skip this test for Hadoop 1.x", HadoopShims.isYARN());
>
> Jaydeep Vishwakarma wrote:
> How does this work. Do you want me to replace this with "if (HadoopShims.isYARN()) {". This test case will not work for 1.x. Please guide me.
Yes. The above statement should be used instead of the if condition. The test will show up as Skipped when run with 1.x instead of Passed. You can refer http://junit.sourceforge.net/javadoc/org/junit/Assume.html
Since patch is already committed, you can just put a amend patch with just this change in same jira and I will +1 for that.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/#review149565
-----------------------------------------------------------
On Aug. 27, 2016, 7:46 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44204/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2016, 7:46 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2243
> https://issues.apache.org/jira/browse/OOZIE-2243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e546e77
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ed06707
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1ea7097
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 5f9e29a
> hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
> hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
> hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
>
> Diff: https://reviews.apache.org/r/44204/diff/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed
when coordinator action get killed
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
> On Sept. 19, 2016, 11:44 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/hadoop/examples/SleepJob.java, lines 166-167
> > <https://reviews.apache.org/r/44204/diff/2/?file=1487473#file1487473line166>
> >
> > Why is this required? Isn't core-site.xml a default resource?
It is default for the launcher job, But when launcher launches the child job it take the core-default and its ports are different. I verified same by debugging and the
> On Sept. 19, 2016, 11:44 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java, line 548
> > <https://reviews.apache.org/r/44204/diff/2/?file=1487474#file1487474line548>
> >
> > Assume.assumeTrue("Skip this test for Hadoop 1.x", HadoopShims.isYARN());
How does this work. Do you want me to replace this with "if (HadoopShims.isYARN()) {". This test case will not work for 1.x. Please guide me.
- Jaydeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/#review149565
-----------------------------------------------------------
On Aug. 27, 2016, 7:46 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44204/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2016, 7:46 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2243
> https://issues.apache.org/jira/browse/OOZIE-2243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e546e77
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ed06707
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1ea7097
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 5f9e29a
> hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
> hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
> hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
>
> Diff: https://reviews.apache.org/r/44204/diff/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed
when coordinator action get killed
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/#review149565
-----------------------------------------------------------
core/src/test/java/org/apache/hadoop/examples/SleepJob.java (lines 166 - 167)
<https://reviews.apache.org/r/44204/#comment217201>
Why is this required? Isn't core-site.xml a default resource?
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 547)
<https://reviews.apache.org/r/44204/#comment217203>
Assume.assumeTrue("Skip this test for Hadoop 1.x", HadoopShims.isYARN());
- Rohini Palaniswamy
On Aug. 27, 2016, 7:46 p.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44204/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2016, 7:46 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2243
> https://issues.apache.org/jira/browse/OOZIE-2243
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e546e77
> core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ed06707
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1ea7097
> core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 5f9e29a
> hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
> hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
> hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
>
> Diff: https://reviews.apache.org/r/44204/diff/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 44204: OOZIE:2243 - Hadoop jobs doesnot get killed
when coordinator action get killed
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44204/
-----------------------------------------------------------
(Updated Aug. 27, 2016, 7:46 p.m.)
Review request for oozie.
Bugs: OOZIE-2243
https://issues.apache.org/jira/browse/OOZIE-2243
Repository: oozie-git
Description
-------
Whenever the coord action or workflow gets killed only the job that has error gets killed while the other hadoop jobs keeps on running and only the workflow status gets changed to killed.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java e546e77
core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java ed06707
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 1ea7097
core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 5f9e29a
hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java dca7820
hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java ce8c14f
hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 94e01ea
Diff: https://reviews.apache.org/r/44204/diff/
Testing
-------
done
Thanks,
Jaydeep Vishwakarma