You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/08/16 09:17:00 UTC
[jira] [Commented] (WICKET-6993) Resource Variations containing a single character are not correctly decoded
[ https://issues.apache.org/jira/browse/WICKET-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580185#comment-17580185 ]
ASF subversion and git services commented on WICKET-6993:
---------------------------------------------------------
Commit 25527239d82143e1983658236a997c371a80b381 in wicket's branch refs/heads/wicket-6993-escape-attributes from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=25527239d8 ]
WICKET-6993: Improve escape/unescape of url attributes (style & variation)
There are still failing tests when `--` is used in an attribute.
The problem is that it is encoded `~~' which later is decoded as '~'.
I don't see any solution here. Whatever scheme we choose for encoding
one can always break it.
The only solution I see is to forbid '--' in attributes, i.e. throw a
RuntimeException.
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
> Resource Variations containing a single character are not correctly decoded
> ---------------------------------------------------------------------------
>
> Key: WICKET-6993
> URL: https://issues.apache.org/jira/browse/WICKET-6993
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 8.14.0, 9.10.0
> Reporter: Peter Lamby
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> A resource variation containing a single character in the middle is encoded as follows:
> single-e-inside => single~e~inside
> When the variation is decoded again the following variation is produced
> single-e~inside => single-e~inside
> A similar issue exists with an attribute like double--separator
>
> The effect is that resources with a variation like that do not work correctly in wicket.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)