You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/04/03 14:28:04 UTC

Review Request 19993: CLOUDSTACK-5674: Minor fixes to BVT test cases in marvin branch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19993/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5674
    https://issues.apache.org/jira/browse/CLOUDSTACK-5674


Repository: cloudstack-git


Description
-------

Minor fixes to few BVT test cases such as
1. Correcting the method call to getZoneForTests
2. Adding list validation
3. Removing services["mode"]. Reading it from zone.networktype


Diffs
-----

  test/integration/smoke/test_network.py dc2e53e 
  test/integration/smoke/test_public_ip_range.py ca3c83b 
  test/integration/smoke/test_secondary_storage.py d430beb 
  test/integration/smoke/test_vm_snapshots.py ca6af31 

Diff: https://reviews.apache.org/r/19993/diff/


Testing
-------

Yes


Thanks,

Gaurav Aradhye


Re: Review Request 19993: CLOUDSTACK-5674: Minor fixes to BVT test cases in marvin branch

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19993/#review39526
-----------------------------------------------------------


Commit 4779e575bb3ff5748f70ba318d42675151c2f40b in cloudstack's branch refs/heads/marvin from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4779e57 ]

CLOUDSTACK-5674: Minor fixes to BVT tests


- ASF Subversion and Git Services


On April 3, 2014, 12:28 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19993/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:28 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5674
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5674
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Minor fixes to few BVT test cases such as
> 1. Correcting the method call to getZoneForTests
> 2. Adding list validation
> 3. Removing services["mode"]. Reading it from zone.networktype
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py dc2e53e 
>   test/integration/smoke/test_public_ip_range.py ca3c83b 
>   test/integration/smoke/test_secondary_storage.py d430beb 
>   test/integration/smoke/test_vm_snapshots.py ca6af31 
> 
> Diff: https://reviews.apache.org/r/19993/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 19993: CLOUDSTACK-5674: Minor fixes to BVT test cases in marvin branch

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19993/#review39525
-----------------------------------------------------------

Ship it!


Ship It!

- Girish Shilamkar


On April 3, 2014, 12:28 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19993/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:28 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5674
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5674
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Minor fixes to few BVT test cases such as
> 1. Correcting the method call to getZoneForTests
> 2. Adding list validation
> 3. Removing services["mode"]. Reading it from zone.networktype
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py dc2e53e 
>   test/integration/smoke/test_public_ip_range.py ca3c83b 
>   test/integration/smoke/test_secondary_storage.py d430beb 
>   test/integration/smoke/test_vm_snapshots.py ca6af31 
> 
> Diff: https://reviews.apache.org/r/19993/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>