[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3314: YARN-10891. Extend QueueInfo with max-parallel-apps in CS.

[GitBox <gi...@apache.org>]

szilard-nemeth commented on a change in pull request #3314:
URL: https://github.com/apache/hadoop/pull/3314#discussion_r694871745



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueue.java
##########
@@ -151,6 +151,12 @@
    * @return current run-state
    */
   public QueueState getState();
+
+  /**
+   * Get the max-parallel-applications property of the queue
+   * @return max-parallel-applications
+   */
+  public int getMaxParallelApps();

Review comment:
       I think it's fine to add getters because it only extends the interface but won't break backwards compatibility.
   
   Looking at the javadoc of InterfaceStability.Stable: 
   ```
     /**
      * Can evolve while retaining compatibility for minor release boundaries.; 
      * can break compatibility only at major release (ie. at m.0).
      */
     @Documented
     @Retention(RetentionPolicy.RUNTIME)
     public @interface Stable {};
   ```
   This also suggests the same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org