You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/21 17:57:38 UTC

[GitHub] [brooklyn-ui] ahgittin commented on pull request #229: Added fix for issue smart-204, version not being updated in the Add ...

ahgittin commented on pull request #229:
URL: https://github.com/apache/brooklyn-ui/pull/229#issuecomment-865232614


   methods starting `get...` i expect to return the value, not write the value in scope.  `populateXxxx` or `setXxxx` might be better choices.
   
   otherwise looks good.
   
   i also prefer @algairim 's pattern but don't feel strongly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org