[GitHub] tragicjun opened a new pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

[GitBox <gi...@apache.org>]

tragicjun opened a new pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs 
URL: https://github.com/apache/flink/pull/6508
 
 
   ## What is the purpose of the change
   
   In the documentation, there is a description: 
   
   > Once registered in a TableEnvironment, all tables defined in a ExternalCatalog can be accessed from Table API or SQL queries by specifying their full path, such as catalog.database.table.
   
   Currently, this is true only for source tables. For sink table (specified in the Table API or SQL), the users have to explicitly register it even though it is defined in a registered ExternalCatalog, otherwise "No table was registered under the name XXX" TableException would be thrown. 
   
   It would be better keep consistent between source table and sink table, and the users would enjoy more convenient approach to inserting into sink tables. This pull request tries to automatically register sink table  if it is defined in any registered external catalogs.
   
   ## Brief change log
   
     - Try automatic registration of sink table in `TableEnvironment.insertInto()`.
     - Add unit test `ExternalCatalogInsertTest` to expose the issue.
     - Create a new external sink table in `CommonTestData.getInMemoryTestCatalog()`. 
   
   ## Verifying this change
   
   This change added unit tests in `ExternalCatalogInsertTest` and can be verified accordingly.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services