You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/08/31 13:35:36 UTC

[GitHub] incubator-zeppelin pull request: Zeppelin-241: Add Setting CRUD Re...

GitHub user eranwitkon opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/268

    Zeppelin-241: Add Setting CRUD Rest API tests

    This PR adds test for the create, Update & delete REST API

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eranwitkon/incubator-zeppelin 241

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #268
    
----
commit b98006917f023aaa442e07b3e98d2cba2e942f04
Author: eranwitkon <go...@gmail.com>
Date:   2015-08-30T11:53:18Z

    Added exclusion strategy class for gson to exclude InterpreterOption from response.
    JsonResponse was updated accordingly to apply this strategy

commit 14e88097553d11cd7e449f66d9ac7ec52b583690
Author: eranwitkon <go...@gmail.com>
Date:   2015-08-30T13:45:36Z

    Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest.
    Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory.

commit f2178f68b853667a68d537d6e6810e6b8d825a07
Author: eranwitkon <go...@gmail.com>
Date:   2015-08-31T05:47:11Z

    Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest.
    Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory.
    Rebase with PR #261 to return new created settings for REST API

commit fdd2bf443de52c9fff4a77269886f87047088cdb
Author: eranwitkon <go...@gmail.com>
Date:   2015-08-31T11:30:25Z

    Implement Setting CRUD REST API tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-241: Add Setting CRUD Re...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-241: Add Setting CRUD Re...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/268#issuecomment-136814507
  
    This PR is ready for merge with pr #266.
    CI is completed successfully but the status is not showing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-241: Add Setting CRUD Re...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/268#issuecomment-136343589
  
    This PR is dependent on PR #266 and should be merged after it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---