You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 06:51:36 UTC

[GitHub] [pulsar] momo-jun opened a new pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

momo-jun opened a new pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206


   ## Modifications
   1. Add a new section "Registering listeners"
   2. Change code example for "Configure TableView"
   
   ## Preview
   ![image](https://user-images.githubusercontent.com/60642177/153321305-1d36e001-8543-411e-ab31-aea1a640447e.png)
   
   ## Documentation
   - [ ] `doc` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a change in pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

Posted by GitBox <gi...@apache.org>.
momo-jun commented on a change in pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206#discussion_r805105053



##########
File path: site2/docs/client-libraries-java.md
##########
@@ -857,6 +854,19 @@ You can use the available parameters in the `loadConf` configuration or related
 | `topic` | string | yes | The topic name of the TableView. | N/A
 | `autoUpdatePartitionInterval` | int | no | The interval to check for newly added partitions. | 60 (seconds)
 
+### Register listeners
+ 
+You can register listeners for both existing messages on a topic and new messages coming into the topic by using `forEachAndListen`, and specify to perform the registration for all existing messages by using `forEach`.

Review comment:
       Thank you. I've corrected the wording. PTAL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14206: [Doc] TableView java client: Add a new section and change code example

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206#issuecomment-1034556218






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206#issuecomment-1035795566


   Hi @nlu90 @Anonymitaet, can you please review this doc PR? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nlu90 commented on a change in pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

Posted by GitBox <gi...@apache.org>.
nlu90 commented on a change in pull request #14206:
URL: https://github.com/apache/pulsar/pull/14206#discussion_r804853388



##########
File path: site2/docs/client-libraries-java.md
##########
@@ -857,6 +854,19 @@ You can use the available parameters in the `loadConf` configuration or related
 | `topic` | string | yes | The topic name of the TableView. | N/A
 | `autoUpdatePartitionInterval` | int | no | The interval to check for newly added partitions. | 60 (seconds)
 
+### Register listeners
+ 
+You can register listeners for both existing messages on a topic and new messages coming into the topic by using `forEachAndListen`, and specify to perform the registration for all existing messages by using `forEach`.

Review comment:
       `perform the registration` -> `perform some operation`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org