You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by getintouchapp <gi...@git.apache.org> on 2017/01/19 13:34:03 UTC
[GitHub] spark pull request #16644: Update LDAExample with Spark 2.1.0
GitHub user getintouchapp opened a pull request:
https://github.com/apache/spark/pull/16644
Update LDAExample with Spark 2.1.0
Changes: Updated code with new Spark 2.x changes
Removed SparkContext and replaced with Spark Session
Fixed compile time errors in new Spark ("Spark Context cannot be initialized here")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/getintouchapp/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16644
----
commit 69b5dd855edd3e5523c8431c9f40bad237739d9e
Author: Ganesh Krishnan <gi...@alphasigma.com.au>
Date: 2017-01-19T13:32:31Z
Update LDAExample with Spark 2.1.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by ganeshkrishnan1 <gi...@git.apache.org>.
Github user ganeshkrishnan1 commented on the issue:
https://github.com/apache/spark/pull/16644
Error:(194, 8) method sparkContext in class Builder cannot be accessed in org.apache.spark.sql.SparkSession.Builder
.sparkContext(sc)
Using Spark 2.1.0 and scala 2.11
I can see the master version using Spark 2.2.0-Snapshot which means this code has been tested with latest version of Spark but I still get this error in my unit tests.
If we don't want to use SparkSession instead of SparkContext we close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16644: Update LDAExample with Spark 2.1.0
Posted by ganeshkrishnan1 <gi...@git.apache.org>.
Github user ganeshkrishnan1 closed the pull request at:
https://github.com/apache/spark/pull/16644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16644
Yes it is. What error do you get? these examples are compiled with the code and compiles correctly in master and previous 2.x builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16644
That code is fine and compiles correctly in master, 2.1, and 2.0. See Jenkins builds. Please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16644
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16644
Please see http://spark.apache.org/contributing.html first
This is an example for .mllib. While it works with 2.x, or should, it is not intended to use SparkSession, as I understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16644: Update LDAExample with Spark 2.1.0
Posted by ganeshkrishnan1 <gi...@git.apache.org>.
Github user ganeshkrishnan1 commented on the issue:
https://github.com/apache/spark/pull/16644
Fails to compile on Spark 2.1.0
Shouldn't mlib be backward compatible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org