You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2016/02/29 07:41:58 UTC

Review Request 44158: Folder name spills out of Upload file window

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44158/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.


Bugs: AMBARI-15217
    https://issues.apache.org/jira/browse/AMBARI-15217


Repository: ambari


Description
-------

- Write a CSS class for wrapping the text.
- Apply the same css for all the modal's heading.


Diffs
-----

  contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9 
  contrib/views/files/src/main/resources/ui/app/templates/components/alert-message.hbs 29a5fa0 
  contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c9b5f1c 

Diff: https://reviews.apache.org/r/44158/diff/


Testing
-------

manual testing done.


Thanks,

Pallav Kulshreshtha


Re: Review Request 44158: Folder name spills out of Upload file window

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44158/#review121399
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 29, 2016, 6:41 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44158/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-15217
>     https://issues.apache.org/jira/browse/AMBARI-15217
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Write a CSS class for wrapping the text.
> - Apply the same css for all the modal's heading.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9 
>   contrib/views/files/src/main/resources/ui/app/templates/components/alert-message.hbs 29a5fa0 
>   contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c9b5f1c 
> 
> Diff: https://reviews.apache.org/r/44158/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 44158: Folder name spills out of Upload file window

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44158/
-----------------------------------------------------------

(Updated March 1, 2016, 10:37 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.


Bugs: AMBARI-15217
    https://issues.apache.org/jira/browse/AMBARI-15217


Repository: ambari


Description
-------

- Write a CSS class for wrapping the text.
- Apply the same css for all the modal's heading.


Diffs (updated)
-----

  contrib/views/files/src/main/resources/ui/app/styles/app.less 3adb91f 
  contrib/views/files/src/main/resources/ui/app/templates/components/alert-message.hbs 29a5fa0 
  contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c9b5f1c 

Diff: https://reviews.apache.org/r/44158/diff/


Testing
-------

manual testing done.


Thanks,

Pallav Kulshreshtha