You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/11/23 10:52:59 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #3857: HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting

virajjasani commented on a change in pull request #3857:
URL: https://github.com/apache/hbase/pull/3857#discussion_r755006739



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
##########
@@ -3712,7 +3712,10 @@ public void snapshot(final String snapshotName, final TableName tableName,
     builder.setTable(tableName.getNameAsString());
     builder.setName(snapshotName);
     builder.setType(type);
-    builder.setTtl(getTtlFromSnapshotProps(snapshotProps));
+    long ttl = getTtlFromSnapshotProps(snapshotProps);
+    if (ttl != 1L && ttl < TimeUnit.MILLISECONDS.toSeconds(Long.MAX_VALUE)) {

Review comment:
       This would be `ttl != -1`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org