[GitHub] [druid] loquisgon commented on a change in pull request #11536: Make persists concurrent with adding rows in batch ingestion

[GitBox <gi...@apache.org>]

loquisgon commented on a change in pull request #11536:
URL: https://github.com/apache/druid/pull/11536#discussion_r686179188



##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/BatchAppenderator.java
##########
@@ -158,6 +169,11 @@
 
     maxBytesTuningConfig = tuningConfig.getMaxBytesInMemoryOrDefault();
     skipBytesInMemoryOverheadCheck = tuningConfig.isSkipBytesInMemoryOverheadCheck();
+    if (tuningConfig.getMaxPendingPersists() < 1) {
+      maxPendingPersists = DEFAULT_PENDING_PERSISTS;

Review comment:
       It just seems reasonable to me... I can go back to the previous default, I have no issues with that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org