You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/31 19:53:15 UTC
[GitHub] [spark] zhouyejoe commented on a diff in pull request #39316: [SPARK-41792][Shuffle] Fix DB update for push based shuffle when newer shuffle merge is received
zhouyejoe commented on code in PR #39316:
URL: https://github.com/apache/spark/pull/39316#discussion_r1059675164
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -227,15 +227,15 @@ AppShufflePartitionInfo getOrCreateAppShufflePartitionInfo(
// Higher shuffleMergeId seen for the shuffle ID meaning new stage attempt is being
// run for the shuffle ID. Close and clean up old shuffleMergeId files,
// happens in the indeterminate stage retries
- AppAttemptShuffleMergeId appAttemptShuffleMergeId =
- new AppAttemptShuffleMergeId(
- appShuffleInfo.appId, appShuffleInfo.attemptId, shuffleId, shuffleMergeId);
+ AppAttemptShuffleMergeId currrentAppAttemptShuffleMergeId =
+ new AppAttemptShuffleMergeId(appShuffleInfo.appId, appShuffleInfo.attemptId,
+ shuffleId, latestShuffleMergeId);
logger.info("{}: creating a new shuffle merge metadata since received " +
- "shuffleMergeId is higher than latest shuffleMergeId {}",
- appAttemptShuffleMergeId, latestShuffleMergeId);
+ "shuffleMergeId {} is higher than latest shuffleMergeId {}",
+ currrentAppAttemptShuffleMergeId, shuffleMergeId, latestShuffleMergeId);
submitCleanupTask(() ->
- closeAndDeleteOutdatedPartitions(
- appAttemptShuffleMergeId, mergePartitionsInfo.shuffleMergePartitions));
+ closeAndDeleteOutdatedPartitions(currrentAppAttemptShuffleMergeId,
+ mergePartitionsInfo.shuffleMergePartitions));
Review Comment:
Nit: 4 spaces for continued lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org