You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2015/10/19 07:31:45 UTC
[GitHub] incubator-hawq pull request: HAWQ-67. Wrong variable type for savi...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/26
HAWQ-67. Wrong variable type for saving fgetc() return value
This is to fix a bug of processing return value of fgetc(). char variable may cut the return value, int is utilized now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-67
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit d768d7273d337eaf11334b1a3653899532be4b7f
Author: Yi Jin <yj...@pivotal.io>
Date: 2015-10-19T05:27:58Z
HAWQ-67. Wrong variable type for saving fgetc() return value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-67. Wrong variable type for savi...
Posted by jianlirong <gi...@git.apache.org>.
Github user jianlirong commented on the pull request:
https://github.com/apache/incubator-hawq/pull/26#issuecomment-149111758
+1, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-67. Wrong variable type for savi...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/26#issuecomment-149107820
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-67. Wrong variable type for savi...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---