You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/10 12:46:18 UTC

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

gaborgsomogyi opened a new pull request, #21288:
URL: https://github.com/apache/flink/pull/21288

   ## What is the purpose of the change
   
   Kafka creation/deletion is an async operation. The API gives back future(s) which must be waited in order to be on the safe side. Additionally the APIs can throw exceptions while waiting to finish. In this PR I've added a more or less consistent Kafka topic creation/deletion behavior to the tests. Namely future wait to all the places where it was missing. This may or may not fix the issue (Kafka itself can be buggy) but I'm pretty sure w/o consistent topic creation/deletion API usage we're in trouble.
   
   ## Brief change log
   
   * Wait for Kafka topic creation/deletion.
   * Add random to test topic names
   
   ## Verifying this change
   
   Existing unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21288:
URL: https://github.com/apache/flink/pull/21288#issuecomment-1310230572

   cc @XComp @gyfora 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21288:
URL: https://github.com/apache/flink/pull/21288#issuecomment-1310233787

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dbc146f45a6d96a54d6901d5639c7b8f335bf2f3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dbc146f45a6d96a54d6901d5639c7b8f335bf2f3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dbc146f45a6d96a54d6901d5639c7b8f335bf2f3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21288:
URL: https://github.com/apache/flink/pull/21288#issuecomment-1310229827

   The only diff here is that there is no `flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java` file so those changes are just not in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #21288: [FLINK-29914][tests][backport] Wait for Kafka topic creation/deletion

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21288:
URL: https://github.com/apache/flink/pull/21288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org