You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/02/11 11:47:00 UTC
[jira] [Commented] (HADOOP-16847) Test TestGroupsCaching fail if
HashSet iterates in a different order
[ https://issues.apache.org/jira/browse/HADOOP-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034365#comment-17034365 ]
Hudson commented on HADOOP-16847:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17937 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17937/])
HADOOP-16847. Test can fail if HashSet iterates in a different order. (github: rev d36cd37e606e03b4c2b7b25b9155fc5ec5dc379d)
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestGroupsCaching.java
> Test TestGroupsCaching fail if HashSet iterates in a different order
> --------------------------------------------------------------------
>
> Key: HADOOP-16847
> URL: https://issues.apache.org/jira/browse/HADOOP-16847
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.2.1
> Reporter: testfixer0
> Assignee: testfixer0
> Priority: Minor
> Fix For: 3.3.0, 3.2.2
>
> Attachments: HADOOP-16847-000.patch, HADOOP-16847-000.patch, HADOOP-16874-001.patch
>
>
> The test `testNegativeGroupCaching` can fail if the iteration order of HashSet changes. In detail, the method `assertEquals` (line 331) compares `groups.getGroups(user)` with an ArrayList `myGroups`. The method `getGroups` converts `allGroups` (a HashSet) to a list and it calls iterator in HashSet. However, the iteration is non-deterministic.
> This PR proposes to modify HashSet to LinkedHashSet for a deterministic order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org