You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/08/29 03:20:18 UTC

[PR] fix(echarts): prevent x-axis time labels from overlapping [superset]

sadpandajoe opened a new pull request, #43669:
URL: https://github.com/apache/superset/pull/43669

   ### SUMMARY
   
   On a time-series chart with the default configuration (0° x-axis label rotation, a resolved time
   grain), ECharts' native label-collision suppression (`axisLabel.hideOverlap`) is disabled. This is a
   deliberate trade-off from a prior fix that guarantees the forced boundary/max date label is never
   hidden by ECharts' own overlap detection, but it has the side effect of disabling overlap suppression
   for every other tick on the axis too — so dense/closely-spaced time labels can render on top of each
   other instead of being thinned or spaced out.
   
   This adds label-level overlap suppression instead of touching the axis-level toggle: a shared
   `createSpacedXAxisFormatter` + `getXAxisDomain` pair (`utils/formatters.ts`) estimates each label's
   rendered pixel footprint against the available per-tick spacing and blanks a label that would
   visually collide with the previously-rendered one, while always keeping the forced boundary labels
   visible. `axisLabel.hideOverlap` stays `false` and the existing boundary-label regression tests are
   untouched.
   
   Applied identically to `Timeseries` and `MixedTimeseries`, replacing the previously duplicated inline
   formatter logic in each (which only deduplicated exact string-duplicate labels, not visually-colliding
   ones).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — this is a label-density/formatter fix validated by unit and integration tests; no manual
   screenshots were captured.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd superset-frontend
   npm run test -- plugins/plugin-chart-echarts/test
   ```
   
   New regression tests reproduce dense/closely-spaced time labels for both `Timeseries` and
   `MixedTimeseries` (confirmed RED before the fix, GREEN after). Full `plugin-chart-echarts` suite:
   994/994 passing.
   
   Manually: create a time-series chart (Line/Area/Bar) with a temporal x-axis and a time grain fine
   enough relative to the selected date range that many points/ticks land close together (e.g. Day grain
   over several months), leave X-Axis Label Rotation at its default (0°) — x-axis labels no longer
   overlap, and the first/last date labels remain visible.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(echarts): prevent x-axis time labels from overlapping [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.

netlify[bot] commented on PR #43669:
URL: https://github.com/apache/superset/pull/43669#issuecomment-5481271983

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | a516f57104ba0a979eaae8a74c39875f595947d2 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a95aa9bc557f50008172d0c |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43669--superset-docs-preview.netlify.app](https://deploy-preview-43669--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQzNjY5LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.pNG57bGSdnl52ESocCSF9uytRxF-AtsgJIW8ugQ0DGc)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5YY1M7Qc9Y12NAkuxCCP6e97mMC_kkvZ8wQTQgSt08Np8spDSohlEpbqdIpILUaQ7lEi5RR9yTM_sWx3JKiLrWCm9KEQ0UvceGb4f) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-43669--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(echarts): prevent x-axis time labels from overlapping [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #43669:
URL: https://github.com/apache/superset/pull/43669#issuecomment-5460062877

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `97.67442%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 79.22%. Comparing base ([`c7cc22f`](https://app.codecov.io/gh/apache/superset/commit/c7cc22f4fee2715688736433eb686475f896c8de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`84552d4`](https://app.codecov.io/gh/apache/superset/commit/84552d42925e3db9a15b040890be2ad16b95f3ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43669?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ugins/plugin-chart-echarts/src/utils/formatters.ts](https://app.codecov.io/gh/apache/superset/pull/43669?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fplugin-chart-echarts%2Fsrc%2Futils%2Fformatters.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvZm9ybWF0dGVycy50cw==) | 97.56% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #43669   +/-   ##
   =======================================
     Coverage   79.21%   79.22%           
   =======================================
     Files        2879     2879           
     Lines      166034   166039    +5     
     Branches    38405    38410    +5     
   =======================================
   + Hits       131530   131539    +9     
   + Misses      32025    32021    -4     
     Partials     2479     2479           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/43669/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/43669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.69% <97.67%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43669?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org