You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2018/11/05 18:56:27 UTC
[09/26] lucene-solr:jira/solr-12730: SOLR-12946: tighten up
request/expectations in test
SOLR-12946: tighten up request/expectations in test
This should prevent some non-reproducible failures where (i think) the problem was inconsistnet background merges between collections being compared, resulting in facet counts (of 0) for terms that weren't in equivilent (merged) indexes.
since the purpose of the test has nothing to do with mincount, force facet.mincount=0 and be more exact about how many terms we expect (in case the root problem lies somewhere else, be more assertive about finding it)
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/05f72a77
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/05f72a77
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/05f72a77
Branch: refs/heads/jira/solr-12730
Commit: 05f72a77efb13517885618597f14cf0d76bd31f7
Parents: 3ed6437
Author: Chris Hostetter <ho...@apache.org>
Authored: Wed Oct 31 15:33:39 2018 -0700
Committer: Chris Hostetter <ho...@apache.org>
Committed: Wed Oct 31 15:33:39 2018 -0700
----------------------------------------------------------------------
.../src/test/org/apache/solr/cloud/DistribCursorPagingTest.java | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/05f72a77/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java b/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
index 46f77c0..59be08a 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
@@ -253,12 +253,14 @@ public class DistribCursorPagingTest extends AbstractFullDistribZkTestBase {
"fl", "id",
"facet", "true",
"facet.field", "str",
+ "facet.mincount", "1",
"json.nl", "map",
"sort", intsort + " asc, id asc");
rsp = query(p(params, CURSOR_MARK_PARAM, cursorMark));
assertNumFound(8, rsp);
assertStartsAt(0, rsp);
assertDocList(rsp, 7, 0, 3);
+ assertEquals(3, rsp.getFacetField("str").getValues().size());
assertEquals("a", rsp.getFacetField("str").getValues().get(0).getName());
assertEquals(4, rsp.getFacetField("str").getValues().get(0).getCount());
cursorMark = assertHashNextCursorMark(rsp);