You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Marvin Humphrey <ma...@rectangular.com> on 2014/02/26 19:21:06 UTC
[VOTE][DISCUSS] Cordova 3.1.0
On Wed, Feb 26, 2014 at 9:27 AM, Ian Clelland <ic...@chromium.org> wrote:
> I'm not sure about the lack of a NOTICE file; it otherwise indicates
> "This product includes software developed by
> Google Code Prettify (http://code.google.com/p/google-code-prettify)"
> which isn't covered by the cordova-3.1.0/NOTIFY file
Comparing the contents of 3.0.0 to 3.1.0, it seems that prettify is in one of
the directories that happened to be stripped
(cordova-docs/template/docs/default/prettify). Since those bits aren't
bundled, there's no need to mention anything in LICENSE/NOTICE.
So there's no problem here that would affect the 3.1.0 release.
Actually, looking at google-code-prettify's licensing, both the bundled
version and the current upstream, they don't include a NOTICE file -- so
mentioning them in cordova-docs/NOTICE is actually a minor licensing
documentation bug. (NOTICE should only include stuff that's absolutely
necessary, so that it's easier for downstream users to consume.) I'd suggest
applying the patch below to cordova-docs.
Cheers,
Marvin Humphrey
--- NOTICE.orig 2014-02-26 10:12:04.000000000 -0800
+++ NOTICE 2014-02-26 10:12:13.000000000 -0800
@@ -4,5 +4,3 @@
This product includes software developed by
The Apache Software Foundation (http://www.apache.org)
-This product includes software developed by
-Google Code Prettify (http://code.google.com/p/google-code-prettify)
Re: [VOTE][DISCUSS] Cordova 3.1.0
Posted by Ian Clelland <ic...@chromium.org>.
Thanks for the clarification, Marvin.
I've created https://issues.apache.org/jira/browse/CB-6113 to track this
for the next release.
On Wed, Feb 26, 2014 at 1:21 PM, Marvin Humphrey <ma...@rectangular.com>wrote:
> On Wed, Feb 26, 2014 at 9:27 AM, Ian Clelland <ic...@chromium.org>
> wrote:
> > I'm not sure about the lack of a NOTICE file; it otherwise indicates
> > "This product includes software developed by
> > Google Code Prettify (http://code.google.com/p/google-code-prettify)"
> > which isn't covered by the cordova-3.1.0/NOTIFY file
>
> Comparing the contents of 3.0.0 to 3.1.0, it seems that prettify is in one
> of
> the directories that happened to be stripped
> (cordova-docs/template/docs/default/prettify). Since those bits aren't
> bundled, there's no need to mention anything in LICENSE/NOTICE.
>
> So there's no problem here that would affect the 3.1.0 release.
>
> Actually, looking at google-code-prettify's licensing, both the bundled
> version and the current upstream, they don't include a NOTICE file -- so
> mentioning them in cordova-docs/NOTICE is actually a minor licensing
> documentation bug. (NOTICE should only include stuff that's absolutely
> necessary, so that it's easier for downstream users to consume.) I'd
> suggest
> applying the patch below to cordova-docs.
>
> Cheers,
>
> Marvin Humphrey
>
> --- NOTICE.orig 2014-02-26 10:12:04.000000000 -0800
> +++ NOTICE 2014-02-26 10:12:13.000000000 -0800
> @@ -4,5 +4,3 @@
> This product includes software developed by
> The Apache Software Foundation (http://www.apache.org)
>
> -This product includes software developed by
> -Google Code Prettify (http://code.google.com/p/google-code-prettify)
>