You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/17 00:44:35 UTC
[GitHub] [dolphinscheduler] zhuxt2015 commented on a diff in pull request #10776: [Fix-10795][plugin] sqoop task query columns bug
zhuxt2015 commented on code in PR #10776:
URL: https://github.com/apache/dolphinscheduler/pull/10776#discussion_r922753677
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/MySQLSourceGenerator.java:
##########
@@ -89,9 +90,11 @@ public String generate(SqoopParameters sqoopParameters, SqoopTaskExecutionContex
.append(SPACE).append(sourceMysqlParameter.getSrcTable());
}
- if (StringUtils.isNotEmpty(sourceMysqlParameter.getSrcColumns())) {
- mysqlSourceSb.append(SPACE).append(COLUMNS)
- .append(SPACE).append(sourceMysqlParameter.getSrcColumns());
+ if(sourceMysqlParameter.getSrcColumnType() == SqoopColumnType.SOME_COLUMNS.getCode()){
+ if (StringUtils.isNotEmpty(sourceMysqlParameter.getSrcColumns())) {
Review Comment:
Please merge two if statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org