You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "rebel-jangys (via GitHub)" <gi...@apache.org> on 2023/03/20 06:41:58 UTC

[GitHub] [tvm] rebel-jangys opened a new pull request, #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

rebel-jangys opened a new pull request, #14340:
URL: https://github.com/apache/tvm/pull/14340

   Fix the issue #14326 
   @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14340:
URL: https://github.com/apache/tvm/pull/14340#issuecomment-1490178917

   @rebel-jangys Thanks for your hard work, it's merged finally!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14340:
URL: https://github.com/apache/tvm/pull/14340#issuecomment-1475701593

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `bugfix` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #14340:
URL: https://github.com/apache/tvm/pull/14340#issuecomment-1477509284

   Can you look at the failed test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-jangys commented on pull request #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

Posted by "rebel-jangys (via GitHub)" <gi...@apache.org>.
rebel-jangys commented on PR #14340:
URL: https://github.com/apache/tvm/pull/14340#issuecomment-1479031657

   SInce this PR corrects the conv3d transpose kernel layout, many frontend relay converters and test cases have to be fixed as well.
   
   For example, the below test case intentionally set wrong kernel_layout to fit in original wrong kernel layout implementation.
   https://github.com/apache/tvm/blob/46fb2ff35f95321e5d76610960c626bfa7a784fc/tests/python/contrib/test_dnnl.py#L479-L490
   
   I’ve fixed pytorch relay converter and some test cases, but I would greatly appreciate any assistance with fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-jangys commented on pull request #14340: [Bugfix] Conv3Dtranspose default kernel layout should be IODHW

Posted by "rebel-jangys (via GitHub)" <gi...@apache.org>.
rebel-jangys commented on PR #14340:
URL: https://github.com/apache/tvm/pull/14340#issuecomment-1490169169

   cc @apeskov , this PR is the one you commented as TODO
   https://github.com/apache/tvm/blob/cbe068cfacbd82d75bfc4914455bbd27652608ac/src/runtime/contrib/dnnl/dnnl_json_runtime.cc#L427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org