You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jean-Baptiste Quenot <jb...@apache.org> on 2007/02/12 11:20:20 UTC
HEADS-UP Cleanup of line endings in source files
Following the [1]earlier discussion about line endings, I'd like
to perform the necessary cleanup ASAP. But as this may be a
little intrusive, it would be better if you could check-in or
revert any pending change to minimize the possibility of a
conflict. I'll do that in branch wicket-1.x. Not every file will
be touched by this cleanup though, it's just a preventive measure.
What is the best time to perform that cleanup? Have you got many
pending changes, or can I perform it now?
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
[1] http://www.nabble.com/Line-endings-in-source-files-tf3188523.html#a8850445
Re: HEADS-UP Cleanup of line endings in source files
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
The cleanup has been performed. Could you please update your
working copies now to reduce the possibility of a conflict?
Thanks,
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: HEADS-UP Cleanup of line endings in source files
Posted by Eelco Hillenius <ee...@gmail.com>.
On 2/13/07, Johan Compagner <jc...@gmail.com> wrote:
> But i hate commandline that is a thing of the past back in the dos days ;)
Only if you use dos you Winnie. :)
Eelco
Re: HEADS-UP Cleanup of line endings in source files
Posted by Igor Vaynberg <ig...@gmail.com>.
i agree 100% this should be a server-side setting
btw if we had access to svn we could configure eclipse to format the code
upon checkin, it has a headless switch for that :|
-igor
On 2/13/07, Johan Compagner <jc...@gmail.com> wrote:
>
> so that is sooo stupid.
> configuring something so it affects all my svn connections.
> as i said is there really no option to configure it on the server where it
> supposed to be?
> Who has designed this .....
>
> johan
>
>
> On 2/13/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> >
> > * Johan Compagner:
> >
> > > For example that file, is that globally? So suddenly for every
> > > svn server i use that?
> >
> > Yes the config file is for all SVN servers. Please make sure to
> > have it configured ASAP to prevent DOS line endings to reappear in
> > our source code.
> > --
> > Jean-Baptiste Quenot
> > aka John Banana Qwerty
> > http://caraldi.com/jbq/
> >
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
so that is sooo stupid.
configuring something so it affects all my svn connections.
as i said is there really no option to configure it on the server where it
supposed to be?
Who has designed this .....
johan
On 2/13/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner:
>
> > For example that file, is that globally? So suddenly for every
> > svn server i use that?
>
> Yes the config file is for all SVN servers. Please make sure to
> have it configured ASAP to prevent DOS line endings to reappear in
> our source code.
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> For example that file, is that globally? So suddenly for every
> svn server i use that?
Yes the config file is for all SVN servers. Please make sure to
have it configured ASAP to prevent DOS line endings to reappear in
our source code.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
But i hate commandline that is a thing of the past back in the dos days ;)
so what about eclipse!
i still think this should be configured on the server
Its a really stupid think to configure on the client except if you could
push it.
For example that file, is that globally? So suddenly for every svn server i
use that?
File ending should be checked and converted on commit
But i think that more stuff should be done by the server (source code
formatting you name it)
Everything that is a project setting about stuff that goes in an out of the
svn repository
should be managed by the repository not by the clients
johan
On 2/12/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> Thx. I'm using commandline exclusively, and this one saved my day!
>
> Martijn
>
> On 2/12/07, Bertrand Delacretaz <bd...@apache.org> wrote:
> > On 2/12/07, Johan Compagner <jc...@gmail.com> wrote:
> > > ...But i am not going to set properties on every new file that i check
> in
> > > So how do i get the right properties (which) by default in eclipse?...
> >
> > FIY, http://www.apache.org/dev/svn-eol-style.txt has an example config
> > for command-line SVN. dunno how to activate this for eclipse though.
> >
> > -Bertrand
> >
>
>
> --
> Vote for Wicket at the
> http://www.thebeststuffintheworld.com/vote_for/wicket
> Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
> http://wicketframework.org
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Martijn Dashorst <ma...@gmail.com>.
Thx. I'm using commandline exclusively, and this one saved my day!
Martijn
On 2/12/07, Bertrand Delacretaz <bd...@apache.org> wrote:
> On 2/12/07, Johan Compagner <jc...@gmail.com> wrote:
> > ...But i am not going to set properties on every new file that i check in
> > So how do i get the right properties (which) by default in eclipse?...
>
> FIY, http://www.apache.org/dev/svn-eol-style.txt has an example config
> for command-line SVN. dunno how to activate this for eclipse though.
>
> -Bertrand
>
--
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org
Re: HEADS-UP Cleanup of line endings in source files
Posted by Upayavira <uv...@odoko.co.uk>.
Johan Compagner wrote:
> can't this be pushed to the server?
> Let the server convert it to the right thing he wants.. And then send me
> back the changes after commit
Typically no, because the server doesn't know your operating system,
your client does. That is the argument, anyhow.
Upayavira
> On 2/12/07, Bertrand Delacretaz <bd...@apache.org> wrote:
>>
>> On 2/12/07, Johan Compagner <jc...@gmail.com> wrote:
>> > ...But i am not going to set properties on every new file that i check
>> in
>> > So how do i get the right properties (which) by default in eclipse?...
>>
>> FIY, http://www.apache.org/dev/svn-eol-style.txt has an example config
>> for command-line SVN. dunno how to activate this for eclipse though.
>>
>> -Bertrand
>>
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
can't this be pushed to the server?
Let the server convert it to the right thing he wants.. And then send me
back the changes after commit
johan
On 2/12/07, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> On 2/12/07, Johan Compagner <jc...@gmail.com> wrote:
> > ...But i am not going to set properties on every new file that i check
> in
> > So how do i get the right properties (which) by default in eclipse?...
>
> FIY, http://www.apache.org/dev/svn-eol-style.txt has an example config
> for command-line SVN. dunno how to activate this for eclipse though.
>
> -Bertrand
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Bertrand Delacretaz <bd...@apache.org>.
On 2/12/07, Johan Compagner <jc...@gmail.com> wrote:
> ...But i am not going to set properties on every new file that i check in
> So how do i get the right properties (which) by default in eclipse?...
FIY, http://www.apache.org/dev/svn-eol-style.txt has an example config
for command-line SVN. dunno how to activate this for eclipse though.
-Bertrand
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
currently JavaHL
But what if i switch to SVNKit?
johan
On 2/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner:
>
> > So how do i get the right properties (which) by default in eclipse?
>
> What SVN plugin do you use?
>
> * Subclipse with JavaHL
> * Subclipse with SVNKit
> * Subversive
>
> Did you checkout http://www.apache.org/dev/svn-eol-style.txt into
> your ~/.subversion/config or ...\Application Data\Subversion\config
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> So how do i get the right properties (which) by default in eclipse?
What SVN plugin do you use?
* Subclipse with JavaHL
* Subclipse with SVNKit
* Subversive
Did you checkout http://www.apache.org/dev/svn-eol-style.txt into
your ~/.subversion/config or ...\Application Data\Subversion\config
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
But i am not going to set properties on every new file that i check in
So how do i get the right properties (which) by default in eclipse?
johan
On 2/12/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Johan Compagner:
>
> > You can start it now as far as i am concerned.
> > I am curious do i check in the files correct?
> > For example the 2 new files i checked in last night: WicketObjectIn and
> > OutputStream
> > are those correct?
>
> To know whether you have the right settings, try:
>
> $ svn proplist src/main/java/wicket/util/io/WicketObjectInputStream.java
>
> It returns nothing, so you didn't set any SVN property. That's
> bad!
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: HEADS-UP Cleanup of line endings in source files
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Johan Compagner:
> You can start it now as far as i am concerned.
> I am curious do i check in the files correct?
> For example the 2 new files i checked in last night: WicketObjectIn and
> OutputStream
> are those correct?
To know whether you have the right settings, try:
$ svn proplist src/main/java/wicket/util/io/WicketObjectInputStream.java
It returns nothing, so you didn't set any SVN property. That's
bad!
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: HEADS-UP Cleanup of line endings in source files
Posted by Johan Compagner <jc...@gmail.com>.
You can start it now as far as i am concerned.
I am curious do i check in the files correct?
For example the 2 new files i checked in last night: WicketObjectIn and
OutputStream
are those correct?
On 2/12/07, Jean-Baptiste Quenot <jbq@apache.org > wrote:
>
> Following the [1]earlier discussion about line endings, I'd like
> to perform the necessary cleanup ASAP. But as this may be a
> little intrusive, it would be better if you could check-in or
> revert any pending change to minimize the possibility of a
> conflict. I'll do that in branch wicket-1.x. Not every file will
> be touched by this cleanup though, it's just a preventive measure.
>
> What is the best time to perform that cleanup? Have you got many
> pending changes, or can I perform it now?
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
> [1]
> http://www.nabble.com/Line-endings-in-source-files-tf3188523.html#a8850445
>