You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/26 11:14:38 UTC
[GitHub] [arrow-rs] alamb opened a new issue, #3199: Add a way to compare datatype for "semantic compatibility / equality"
alamb opened a new issue, #3199:
URL: https://github.com/apache/arrow-rs/issues/3199
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
In https://github.com/apache/arrow-datafusion/issues/4346 from DataFusion, we have a check that between each optimization pass the schema hasn't changed (see https://github.com/apache/arrow-datafusion/pull/4233 by @jackwener).
However it turns out that some passes may change the metadata or nullability for a plan which is ok, but this causes the schema equality check to fail incorrectly
**Describe the solution you'd like**
I would like a function that does "semanic equality" checking of a datatype -- specifically one that ignores any metadata or nullability information and only compares:
1. field_name
2. data_type
**Describe alternatives you've considered**
We can keep the code entirely in datafusion -- see initial implementation in https://github.com/apache/arrow-datafusion/pull/4347
**Additional context**
As suggested by @mingmwang on https://github.com/apache/arrow-datafusion/pull/4347#issuecomment-1325885678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #3199: Add a way to compare datatype for "semantic compatibility / equality"
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #3199:
URL: https://github.com/apache/arrow-rs/issues/3199#issuecomment-1328102949
Perhaps we could modify https://docs.rs/arrow-schema/27.0.0/arrow_schema/enum.DataType.html#method.equals_datatype to not take account of nullability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #3199: Add a way to compare datatype for "semantic compatibility / equality"
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3199:
URL: https://github.com/apache/arrow-rs/issues/3199#issuecomment-1328237262
that sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org