You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/06/06 13:13:55 UTC

Review Request 59840: Fixed googletest target name in mesos-tidy script.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59840/
-----------------------------------------------------------

Review request for mesos, Michael Park, Neil Conway, and Jan Schlicht.


Repository: mesos


Description
-------

Fixed googletest target name in mesos-tidy script.


Diffs
-----

  support/mesos-tidy/entrypoint.sh 6ef7835710d339ea3b378deb07f502ad1c910cd4 


Diff: https://reviews.apache.org/r/59840/diff/1/


Testing
-------

Tested building the `mesos-tidy` docker image locally.


Thanks,

Benjamin Bannier


Re: Review Request 59840: Fixed googletest target name in mesos-tidy script.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59840/#review177037
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59840]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 6, 2017, 1:13 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59840/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 1:13 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed googletest target name in mesos-tidy script.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh 6ef7835710d339ea3b378deb07f502ad1c910cd4 
> 
> 
> Diff: https://reviews.apache.org/r/59840/diff/1/
> 
> 
> Testing
> -------
> 
> Tested building the `mesos-tidy` docker image locally.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 59840: Fixed googletest target name in mesos-tidy script.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59840/#review177047
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On June 6, 2017, 1:13 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59840/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 1:13 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed googletest target name in mesos-tidy script.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh 6ef7835710d339ea3b378deb07f502ad1c910cd4 
> 
> 
> Diff: https://reviews.apache.org/r/59840/diff/1/
> 
> 
> Testing
> -------
> 
> Tested building the `mesos-tidy` docker image locally.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>