You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/04/29 16:33:17 UTC

[GitHub] [submarine] Kenchu123 opened a new pull request #573: Submarine 807

Kenchu123 opened a new pull request #573:
URL: https://github.com/apache/submarine/pull/573


   ---
   tags: apache, submarine
   ---
   ### What is this PR for?
   
   Create a submarine tensorboard for a single user via the submarine operator.
   
   Reference: https://github.com/apache/submarine/blob/master/helm-charts/submarine/templates/submarine-tensorboard.yaml
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-807
   
   ### How should this be tested?
   
   ```
   # initialization
   # Step1: Register Custom Resource Definition
   kubectl apply -f artifacts/examples/crd.yaml
   
   # Step2: Create a Custom Resource
   kubectl apply -f artifacts/examples/example-submarine.yaml
   
   # in-cluster
   cd submarine/submarine-cloud-v2
   eval $(minikube docker-env)
   make image
   kubectl apply -f artifacts/examples/submarine-operator-service-account.yaml
   kubectl apply -f artifacts/examples/submarine-operator.yaml
   
   # out-of-cluster
   go build -o submarine-operator
   ./submarine-operator
   
   # helm
   cd submarine
   helm install submarine ./helm-charts/submarine
   
   ```
   
   ### Screenshots (if appropriate)
   
   + PersistentVolume (helm)
   
   ![helm-pv](https://i.imgur.com/DTpR0KG.png)
   
   + PersistentVolume (operator)
   
   **Note**: PersistentVolumes are not namespaced resources, so we add the namespace as a suffix to distinguish them
   
   ![operator-pv](https://i.imgur.com/Iq3g2pv.png)
   
   
   + PersistentVolumeClaim (helm)
   
   ![helm-pvc](https://i.imgur.com/84CiP33.png)
   
   
   + PersistentVolumeClaim (operator)
   
   ![operator-pvc](https://i.imgur.com/v7ijQGf.png)
   
   
   + Deployment (helm)
   
   ![helm-deployment](https://i.imgur.com/QN6MvaA.png)
   
   + Deployment (operator)
   
   ![operator-deployment](https://i.imgur.com/hjfKhHC.png)
   
   + Service (helm)
   
   ![helm-service](https://i.imgur.com/nPSC1sW.png)
   
   + Service (opertator)
   
   ![operator-service](https://i.imgur.com/iZthCWr.png)
   
   
   + IngressRoute (helm)
   
   ![helm-ingressroute](https://i.imgur.com/g2UnyFf.png)
   
   + IngressRoute (operator)
   
   ![operator-ingressroute](https://i.imgur.com/3KDhs35.png)
   
   
   + Workbench
   
   [Video](https://imgur.com/9Wk8Rnh)
   
   ### Questions:
   
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness removed a comment on pull request #573: SUBMARINE-807. Create a tensorboard for a single user

Posted by GitBox <gi...@apache.org>.
MortalHappiness removed a comment on pull request #573:
URL: https://github.com/apache/submarine/pull/573#issuecomment-830991782


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #573: SUBMARINE-807. Create a tensorboard for a single user

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #573:
URL: https://github.com/apache/submarine/pull/573#issuecomment-830825215


   @MortalHappiness Can you help Ken review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #573: SUBMARINE-807. Create a tensorboard for a single user

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #573:
URL: https://github.com/apache/submarine/pull/573


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #573: SUBMARINE-807. Create a tensorboard for a single user

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #573:
URL: https://github.com/apache/submarine/pull/573#issuecomment-830991782


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org