You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2009/06/09 18:19:07 UTC
[jira] Created: (SOLR-1212) TestNG Test Case
TestNG Test Case
-----------------
Key: SOLR-1212
URL: https://issues.apache.org/jira/browse/SOLR-1212
Project: Solr
Issue Type: New Feature
Components: clients - java
Affects Versions: 1.4
Environment: Java 6
Reporter: Kay Kay
Fix For: 1.5
TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
New Class created: AbstractSolrNGTest
LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
TestNG 5.9-jdk15 added to lib.
Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1212) TestNG Test Case
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-1212:
--------------------------
Attachment: testng-5.9-jdk15.jar
TestNG 5.9
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1212) TestNG Test Case
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated SOLR-1212:
--------------------------
Attachment: SOLR-1212.patch
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797004#action_12797004 ]
Kay Kay commented on SOLR-1212:
-------------------------------
@Shalin , @HossMan - I understand the pain of maintaining this one separate from Junit - but was concerned mostly about this being out of date with the tree.
As regarding comparison between TestNG vs JUnit - one big advantage is to categorize the tests as different groups in testng and run them separately (especially useful as the code base of solr gets bigger + contrib ). Which is one of the primary reasons (After evaluating both ) - testng was chosen. So - if you guys are not comfortable with the patch - then (as shalin noted) - just make an entry in the wiki and leave this one as such. The code is definitely not big to warrant a sf project / github / google code at this point.
A better patch would be to refactor existing JUnit Test case so that the testng version minimizes duplication as much as possible.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795118#action_12795118 ]
Kay Kay commented on SOLR-1212:
-------------------------------
Keeping this out of the codebase would result in the patch being out of sync with the tree. If there were no licensing restrictions - what is the harm in having this in the tree.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797005#action_12797005 ]
Kay Kay commented on SOLR-1212:
-------------------------------
@HossMan - Interesting thread from stackoverflow - http://stackoverflow.com/questions/153427/is-there-a-junit-testrunner-for-running-groups-of-tests . Not sure - how much of junit has kept up with TestNG recently but TestNG is definitely a notch up (IMHO, of course).
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796123#action_12796123 ]
Shalin Shekhar Mangar commented on SOLR-1212:
---------------------------------------------
bq. Keeping this out of the codebase would result in the patch being out of sync with the tree. If there were no licensing restrictions - what is the harm in having this in the tree.
You wrote this because you needed it at work and I appreciate that you thought about contributing it to Solr. But from Solr's perspective it is not needed and therefore I don't see why we should ship it at all. It is a class that is not used by Solr but would need to be maintained by us if we ship it.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790648#action_12790648 ]
Shalin Shekhar Mangar commented on SOLR-1212:
---------------------------------------------
I'm not sure what to do with this. We don't need to ship this with our releases. Perhaps it is best to mark this as "Won't Fix" and link this issue to http://wiki.apache.org/solr/TestingSolr so that people who use TestNG can use this code if necessary.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1212) TestNG Test Case
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796953#action_12796953 ]
Hoss Man commented on SOLR-1212:
--------------------------------
I'm on the fence ...
i agree it's (probably) useful to TestNG users and i would like to do as much as possible to make it easy for people to use the TestHarness (regardless of how they write tests) but the idea of including it in the release does "smell fishy" if we're not actually using it anywhere in Solr -- it may not seem like much overhead to maintain it, but if it never gets used internally then it's not really clear if/when there are problems with it (even Test code needs to be tested to be sure that it's not broken).
If it's not included in the Solr repository, then it may fall out of sync with Solr -- but that's true of any plugin someone writes and hosts on sourceforge, or github, or googlecode -- we can advertise that it works with Solr 1.4, and if something changes in Solr 1.5, or Solr 1.6 or Solr 9.7 that breaks it then interested parties are free to update it with new version that does work.
...If i knew more about TestNG i might be able to form a stronger opinion like "this is awesome, it's super useful, we should include it" or "this doesn't really provide any value add to users" but I just don't know enough either way.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.