You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by mb...@apache.org on 2017/07/26 21:22:59 UTC
systemml git commit: [MINOR] Modified codegen rowagg test (smaller
value range of outputs)
Repository: systemml
Updated Branches:
refs/heads/master 5fa84ccfa -> 7ae1b1c4c
[MINOR] Modified codegen rowagg test (smaller value range of outputs)
This particular test case created outputs in the range of 10^19. Due to
our absolute epsilon of 10^{-10}, even tiny differences to R led to test
failures (this test failed on jenkins after an update to R 3.4).
Project: http://git-wip-us.apache.org/repos/asf/systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/7ae1b1c4
Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/7ae1b1c4
Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/7ae1b1c4
Branch: refs/heads/master
Commit: 7ae1b1c4c46ab8741b06a5a77d4fff1aa2f06f87
Parents: 5fa84cc
Author: Matthias Boehm <mb...@gmail.com>
Authored: Wed Jul 26 14:24:10 2017 -0700
Committer: Matthias Boehm <mb...@gmail.com>
Committed: Wed Jul 26 14:24:22 2017 -0700
----------------------------------------------------------------------
src/test/scripts/functions/codegen/rowAggPattern30.R | 6 +++---
src/test/scripts/functions/codegen/rowAggPattern30.dml | 8 +++++---
2 files changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/systemml/blob/7ae1b1c4/src/test/scripts/functions/codegen/rowAggPattern30.R
----------------------------------------------------------------------
diff --git a/src/test/scripts/functions/codegen/rowAggPattern30.R b/src/test/scripts/functions/codegen/rowAggPattern30.R
index 28300e7..10e82cd 100644
--- a/src/test/scripts/functions/codegen/rowAggPattern30.R
+++ b/src/test/scripts/functions/codegen/rowAggPattern30.R
@@ -24,9 +24,9 @@ options(digits=22)
library("Matrix")
library("matrixStats")
-X = matrix(seq(1,6000), 600, 10, byrow=TRUE);
-ssX_V = matrix(seq(1,40), 10, 4, byrow=TRUE);
-P = matrix(seq(1,3000), 600, 5, byrow=TRUE);
+X = matrix(seq(1,6000), 600, 10, byrow=TRUE)/6000;
+ssX_V = matrix(seq(1,40), 10, 4, byrow=TRUE)/40;
+P = matrix(seq(1,3000), 600, 5, byrow=TRUE)/3000;
K = 4;
Q = P[,1:K] * (X %*% ssX_V);
http://git-wip-us.apache.org/repos/asf/systemml/blob/7ae1b1c4/src/test/scripts/functions/codegen/rowAggPattern30.dml
----------------------------------------------------------------------
diff --git a/src/test/scripts/functions/codegen/rowAggPattern30.dml b/src/test/scripts/functions/codegen/rowAggPattern30.dml
index 0cfbc5d..a130b82 100644
--- a/src/test/scripts/functions/codegen/rowAggPattern30.dml
+++ b/src/test/scripts/functions/codegen/rowAggPattern30.dml
@@ -20,13 +20,15 @@
#-------------------------------------------------------------
-X = matrix(seq(1,6000), 600, 10);
-ssX_V = matrix(seq(1,40), 10, 4);
-P = matrix(seq(1,3000), 600, 5);
+X = matrix(seq(1,6000), 600, 10)/6000;
+ssX_V = matrix(seq(1,40), 10, 4)/40;
+P = matrix(seq(1,3000), 600, 5)/3000;
K = 4;
if(1==1){}
Q = P[,1:K] * (X %*% ssX_V);
R = t(X) %*% (Q - P[,1:K] * rowSums(Q));
+print(max(R));
+
write(R, $1)