[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320858976
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/SpaceQuotaHelperForTests.java
 ##########
 @@ -271,6 +271,17 @@ void setQuotaLimit(final TableName tn, SpaceViolationPolicy policy, long sizeInM
     LOG.debug("Quota limit set for table = {}, limit = {}", tn, sizeLimit);
   }
 
+  /**
+   * Sets the given quota (policy & limit) on the passed namespace.
+   */
+  void setQuotaLimitNamespace(final String namespace, SpaceViolationPolicy policy, long sizeInMBs)
 
 Review comment:
   Can you please fix `setQuotaLimit()` and `removeQuotaFromtable` to be consistent with these new methods?
   
   e.g. `setQuotaLimitTable()` and `removeQuotaFromTable()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services