You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/08/23 21:25:15 UTC

[GitHub] [storm] dandsager1 commented on a change in pull request #3114: STORM-3488 Scheduling can cause RAS_Node resources to become negative

dandsager1 commented on a change in pull request #3114: STORM-3488 Scheduling can cause RAS_Node resources to become negative
URL: https://github.com/apache/storm/pull/3114#discussion_r317306994
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java
 ##########
 @@ -739,6 +740,20 @@ private double calculateSharedOffHeapNodeMemory(
         return memorySharedWithinNode;
     }
 
+    // special case for calculateSharedOffHeapMemory, where assignment is null
+    private double calculateSharedOffHeapNodeMemoryForUnassignedSlot(TopologyDetails td, ExecutorDetails exec) {
 
 Review comment:
   renamed as overload. unified parameter list would need 4 params; seems cleaner to add overload with 2 params.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services