You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Szabolcs Berecz (JIRA)" <ji...@apache.org> on 2011/08/22 23:50:29 UTC
[jira] [Created] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Camel-netty option "encoder" and "decoder" does not work
--------------------------------------------------------
Key: CAMEL-4367
URL: https://issues.apache.org/jira/browse/CAMEL-4367
Project: Camel
Issue Type: Bug
Components: camel-netty
Affects Versions: 2.8.0, 2.7.3, 2.7.2, 2.7.1, 2.7.0, 2.6.0, 2.5.0, 2.4.0
Reporter: Szabolcs Berecz
Priority: Minor
Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "edge wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089623#comment-13089623 ]
edge wang commented on CAMEL-4367:
----------------------------------
Well, as I said , I don't see the original implementation as a bug, so if all others accept the new way -- maybe as an improvement -- we will check to make sure the side-effects don't affect our current code. Of course as Jiang said, if one use "#" in property value for reference as default, there should be no harm.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
> Attachments: CAMEL-4367.patch
>
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Szabolcs Berecz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szabolcs Berecz updated CAMEL-4367:
-----------------------------------
Description:
Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
This bug was introduced in the revision 960621 as part of CAMEL-2907.
was:
Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089189#comment-13089189 ]
Willem Jiang commented on CAMEL-4367:
-------------------------------------
Hi Szabolcs,
Thanks for the patch.
Can you submit the patch to the JIRA and grant it with Apache license ?
So I can apply it into trunk.
Willem
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "edge wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089331#comment-13089331 ]
edge wang commented on CAMEL-4367:
----------------------------------
Hi, all
Actually I don't see it as a bug in this case, the documentation clearly says that when "encoder" and "decoder" is used, the property value should be a class' name inheriting org.jboss.netty.channel.ChannelDownStreamHandler/org.jboss.netty.channel.ChannelUpStreamHandler, if you need to resolve the class from registry, please use the "encoders" and "decoders".
Although it's a good idea that the "encoder" and "decoder" property can also be resolved from registry, please make sure that the call to
EndpointHelper.setReferenceProperties(component.getCamelContext(), this, parameters);
doesn't introduce any side-effects.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Szabolcs Berecz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szabolcs Berecz updated CAMEL-4367:
-----------------------------------
Patch Info: [Patch Available]
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-4367:
-----------------------------------
Assignee: Willem Jiang
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: CAMEL-4367.patch
>
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Szabolcs Berecz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szabolcs Berecz updated CAMEL-4367:
-----------------------------------
Attachment: CAMEL-4367.patch
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
> Attachments: CAMEL-4367.patch
>
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Szabolcs Berecz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089339#comment-13089339 ]
Szabolcs Berecz commented on CAMEL-4367:
----------------------------------------
Hi all,
It looks like I misunderstood the documentation. Anyway, if you think it's a good idea to use the registry for these two options, I will submit the patch.
Actually, the call to setReferenceProperties does introduce side-effects as it will try to resolve from registry every option value with a leading "#". The question is, do you see it as a bad thing?
If you would rather only have the "encoder" and "decoder" option resolved from registry, I will update the patch.
Szabolcs
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089344#comment-13089344 ]
Willem Jiang commented on CAMEL-4367:
-------------------------------------
I just checked the camel-netty wiki page, it said it supports the encoder and decoder option, the "#" is used for reference in camel by default, I don't think it is wrong.
@Szabolcs
I'm OK with your patch, once you submit the patch, I will be happy to apply it into trunk.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Szabolcs Berecz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szabolcs Berecz updated CAMEL-4367:
-----------------------------------
Description:
Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
This bug was introduced in the revision 960621 as part of CAMEL-2907.
Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
was:
Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Priority: Minor
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-4367) Camel-netty option "encoder" and
"decoder" does not work
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-4367.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.9.0
2.8.1
Applied patch into trunk and 2.8.x branch.
> Camel-netty option "encoder" and "decoder" does not work
> --------------------------------------------------------
>
> Key: CAMEL-4367
> URL: https://issues.apache.org/jira/browse/CAMEL-4367
> Project: Camel
> Issue Type: Bug
> Components: camel-netty
> Affects Versions: 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.8.0
> Reporter: Szabolcs Berecz
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.8.1, 2.9.0
>
> Attachments: CAMEL-4367.patch
>
>
> Contrary to the documentation, the "encoder" and "decoder" option is unusable as it's value is taken as-is instead of resolving the references using the registry.
> This bug was introduced in the revision 960621 as part of CAMEL-2907.
> Patch can be found at https://github.com/szabolcsberecz/camel/commit/b3bcc8dd284575c931048ea410c44577474e25dd
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira