You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin McCabe <cm...@cloudera.com> on 2016/07/14 23:20:02 UTC
Review Request 50055: SENTRY-1404 Use the new INodeAttributesProvider
API in sentry-hdfs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50055/
-----------------------------------------------------------
Review request for sentry, Anne Yu, Hao Hao, and Sravya Tirukkovalur.
Bugs: SENTRY-1404
https://issues.apache.org/jira/browse/SENTRY-1404
Repository: sentry
Description
-------
SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs
Diffs
-----
pom.xml 2ea4735
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/hadoop/hdfs/server/namenode/AuthorizationProvider.java 383d64d
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java f639f5f
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java PRE-CREATION
sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryAuthorizationProvider.java 2085b52
sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryINodeAttributesProvider.java PRE-CREATION
sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java 5da0dc2
sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryINodeAttributesProvider.java PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/NoAuthorizationProvider.java be0830d
sentry-provider/sentry-provider-common/src/test/java/org/apache/sentry/provider/common/TestNoAuthorizationProvider.java fe01b06
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 4d0c4b5
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java f2d74bf
Diff: https://reviews.apache.org/r/50055/diff/
Testing
-------
Thanks,
Colin McCabe
Re: Review Request 50055: SENTRY-1404 Use the new
INodeAttributesProvider API in sentry-hdfs
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50055/#review143146
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 25)
<https://reviews.apache.org/r/50055/#comment208897>
Change to import explict package?
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 77)
<https://reviews.apache.org/r/50055/#comment208887>
Should use isSentryManaged instead of isManaged? Since isManaged is deprecated. Same as other places.
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 79)
<https://reviews.apache.org/r/50055/#comment208884>
Why not perform permission check for mangaed path as well?
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 131)
<https://reviews.apache.org/r/50055/#comment208892>
So we need to consider isStale case here, since no matter it is stale or not, should use defaultAttributes.getUserName()? Same as getGroupName and getFsPermission.
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 191)
<https://reviews.apache.org/r/50055/#comment208895>
Need to check if is sentry managed path first?
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java (line 315)
<https://reviews.apache.org/r/50055/#comment208890>
This logic has be occur in multiple places. Would be good to wrap it in a method? And can you comment on why do we need the checking here?
- Hao Hao
On July 14, 2016, 11:20 p.m., Colin McCabe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50055/
> -----------------------------------------------------------
>
> (Updated July 14, 2016, 11:20 p.m.)
>
>
> Review request for sentry, Anne Yu, Hao Hao, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1404
> https://issues.apache.org/jira/browse/SENTRY-1404
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1404: Use the new INodeAttributesProvider API in sentry-hdfs
>
>
> Diffs
> -----
>
> pom.xml 2ea4735
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/hadoop/hdfs/server/namenode/AuthorizationProvider.java 383d64d
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java f639f5f
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java PRE-CREATION
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryAuthorizationProvider.java 2085b52
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryINodeAttributesProvider.java PRE-CREATION
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java 5da0dc2
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryINodeAttributesProvider.java PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/NoAuthorizationProvider.java be0830d
> sentry-provider/sentry-provider-common/src/test/java/org/apache/sentry/provider/common/TestNoAuthorizationProvider.java fe01b06
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 4d0c4b5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java f2d74bf
>
> Diff: https://reviews.apache.org/r/50055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin McCabe
>
>