You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/13 19:21:02 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #23069: Issue#21430 Avoid pruning DataframeTransforms

TheNeuralBit commented on code in PR #23069:
URL: https://github.com/apache/beam/pull/23069#discussion_r970001529


##########
sdks/python/apache_beam/runners/interactive/pipeline_fragment.py:
##########
@@ -233,3 +234,9 @@ def visit_transform(self, transform_node):
     v = PruneVisitor()
     runner_pipeline.visit(v)
     return runner_pipeline
+
+
+def should_skip_pruning(transform: AppliedPTransform):
+  return (
+      isinstance(transform.transform, TestStream) or
+      '_DataFrame_' in transform.full_label)

Review Comment:
   can we match on is instance `DataframeTransform` instead of string matching?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org