You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/05/04 16:19:04 UTC

[jira] [Commented] (ACCUMULO-4634) MockIteratorEnvironment implementation broken in mock accumulo framework

    [ https://issues.apache.org/jira/browse/ACCUMULO-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997011#comment-15997011 ] 

Josh Elser commented on ACCUMULO-4634:
--------------------------------------

bq.  Granted this whole MockAccumulo mechanism is deprecated

Did we just not remove it in 2.0 yet? That's surprising, people seem to love removing deprecated code asap :)

> MockIteratorEnvironment implementation broken in mock accumulo framework
> ------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4634
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4634
>             Project: Accumulo
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.8.0
>            Reporter: Ivan Bella
>            Assignee: Ivan Bella
>              Labels: mock
>             Fix For: 1.8.2, 2.0.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The MockIteratorEnvironment was broken when the additional sampling methods were added.  The isSamplingEnabled throws an unsupported operation exception instead of simply returning false.  Also the getSamplerConfiguration should return null and the cloneWithSamplingEnabled should throw a SampleNotPresentException instead an UnsupportedOperationException per the documentation in the IteratorEnvironment interface.  This will allow its use to work smoothly as before.  Granted this whole MockAccumulo mechanism is deprecated, however external projects still have dependencies on it and hence we should not have broken its implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)