You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2011/02/26 04:41:21 UTC
[jira] Created: (HDFS-1665) Balancer sleeps inadequately
Balancer sleeps inadequately
----------------------------
Key: HDFS-1665
URL: https://issues.apache.org/jira/browse/HDFS-1665
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Priority: Minor
The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1665) Balancer sleeps inadequately
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004929#comment-13004929 ]
Hudson commented on HDFS-1665:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #555 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/555/])
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.1, Federation Branch, 0.22.0, 0.23.0
>
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1665) Balancer sleeps inadequately
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003256#comment-13003256 ]
Todd Lipcon commented on HDFS-1665:
-----------------------------------
+1, good catch
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Description: The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it. (was: The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.)
Hadoop Flags: [Reviewed]
Thanks Todd for the review.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1665) Balancer sleeps inadequately
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022985#comment-13022985 ]
Hudson commented on HDFS-1665:
------------------------------
Integrated in Hadoop-Hdfs-22-branch #35 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/])
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.1, Federation Branch, 0.22.0, 0.23.0
>
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Attachment: h1665_20110225.patch
h1665_20110225.patch: changed 2 to 2000.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003576#comment-13003576 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1665:
----------------------------------------------
I forgot to say that I did not add new tests since the changes are obvious.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.1, Federation Branch, 0.22.0, 0.23.0
>
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
0.22.0
Federation Branch
0.21.1
Status: Resolved (was: Patch Available)
I have committed this.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.1, Federation Branch, 0.22.0, 0.23.0
>
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Attachment: h1665_20110225b_fed.patch
h1665_20110225b_fed.patch: for federation
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Attachment: (was: h1665_20110225.patch)
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1665) Balancer sleeps inadequately
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022429#comment-13022429 ]
Hudson commented on HDFS-1665:
------------------------------
Integrated in Hadoop-Hdfs-trunk #643 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.21.1, Federation Branch, 0.22.0, 0.23.0
>
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Attachment: h1665_20110225b.patch
h1665_20110225b.patch: removed an unnecessary synchronization.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1665) Balancer sleeps inadequately
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003573#comment-13003573 ]
Hadoop QA commented on HDFS-1665:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12472858/h1665_20110225b_fed.patch
against trunk revision 1078925.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/235//console
This message is automatically generated.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch, h1665_20110225b_fed.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in seconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Status: Patch Available (was: Open)
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Attachment: h1665_20110225.patch
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1665) Balancer sleeps inadequately
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1665:
-----------------------------------------
Component/s: balancer
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1665) Balancer sleeps inadequately
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001039#comment-13001039 ]
Hadoop QA commented on HDFS-1665:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12472015/h1665_20110225b.patch
against trunk revision 1075571.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//console
This message is automatically generated.
> Balancer sleeps inadequately
> ----------------------------
>
> Key: HDFS-1665
> URL: https://issues.apache.org/jira/browse/HDFS-1665
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h1665_20110225.patch, h1665_20110225b.patch
>
>
> The value of {{dfs.heartbeat.interval}} is in milliseconds. Balancer seems misused it.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira